Skip to content

Conversation

@linnealaux
Copy link

The sad part is that it was nearly done by class on Thursday, but there was no physical chance for me to do work Friday or Saturday and I am also in other classes.

Review on Reviewable

@YuzhongHuang
Copy link

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 5 unresolved discussions.


a discussion (no related file):
Interesting project. But the scope is a little bit limited. There are some changes could be made to make the code more concise and clean. I've suggested some changes in the comments. Please take a look!

Although the code is relatively self-explanatory, adding some comments would make the project much more readable.

Looking forward to your future work!


therapyanal.py, line 1 [r1] (raw file):
A brief heading describing what does the code do overall would be helpful for others to understand


therapyanal.py, line 173 [r1] (raw file):
Put the replacements into a function would be good. Also, instead of doing this by yourself, you can use 'nltk' package to get nltk.stop_word list, which is much more comprehensive. Being lazy is important.


therapyanal.py, line 174 [r1] (raw file):
Adding some docstring to explain what the function is doing here


therapyanal.py, line 196 [r1] (raw file):
Add some comments for the indexing.


Comments from the review on Reviewable.io

from pattern.en import *
#this is the list of things that will be cleaned out, in the order that they
#will be cleaned out. i determined this through trial.
badthings = ['\\n','lists.olin.edu','Anonymous rants and raves','Original',
Copy link

@LucyWilcox LucyWilcox May 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but you probably could have done a bit more cleaning up, or something else in addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants