Skip to content

Conversation

@staabm
Copy link
Contributor

@staabm staabm commented Dec 19, 2025

attribute name needs to be unique

closes #1131


this regressed in 5b74f62 which previously used DOM to de-duplicate the attribute name automatically because it just overwrote the previous value

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.42%. Comparing base (9654885) to head (2bf6ded).
⚠️ Report is 7 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1132   +/-   ##
=========================================
  Coverage     88.42%   88.42%           
  Complexity     1390     1390           
=========================================
  Files           105      105           
  Lines          4700     4700           
=========================================
  Hits           4156     4156           
  Misses          544      544           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stijnh92
Copy link

Can confirm that this works and generates valid XML.

@sebastianbergmann
Copy link
Owner

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it.

@staabm staabm closed this Dec 19, 2025
@staabm staabm deleted the xdeb branch December 19, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid XML generated when both PCOV and Xdebug are loaded

3 participants