-
Notifications
You must be signed in to change notification settings - Fork 858
Refactor of p2p secret connection #2650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 7aacf5b.
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2650 +/- ##
=======================================
Coverage 43.78% 43.78%
=======================================
Files 1904 1903 -1
Lines 158932 158907 -25
=======================================
- Hits 69585 69581 -4
+ Misses 82944 82929 -15
+ Partials 6403 6397 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| if counter == math.MaxUint64 { | ||
| // Terminates the session and makes sure the nonce would not re-used. | ||
| // See https://github.com/tendermint/tendermint/issues/3531 | ||
| panic("can't increase nonce without overflow") |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| return n, err | ||
| } | ||
| return n, err | ||
| panic("unreachable") |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
Refactored secret connection implementation, preparing it to multiplex between v2 and giga connections during handshake. In particular the handshake is now context aware. Additional changes: