Skip to content

Conversation

@pompon0
Copy link
Contributor

@pompon0 pompon0 commented Jan 1, 2026

Refactored secret connection implementation, preparing it to multiplex between v2 and giga connections during handshake. In particular the handshake is now context aware. Additional changes:

  • removed gogo annotations from p2p protos
  • merged crypto/encoding package into crypto (for simplicity)

@github-actions
Copy link

github-actions bot commented Jan 1, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJan 1, 2026, 4:29 PM

@pompon0 pompon0 changed the title Gprusak validator proto2 Refactor of p2p secret connection Jan 1, 2026
@codecov
Copy link

codecov bot commented Jan 1, 2026

Codecov Report

❌ Patch coverage is 73.99103% with 58 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.98%. Comparing base (884e779) to head (4de17dc).

Files with missing lines Patch % Lines
...-tendermint/internal/p2p/conn/secret_connection.go 85.13% 15 Missing and 7 partials ⚠️
sei-cosmos/crypto/codec/tm.go 0.00% 12 Missing ⚠️
sei-tendermint/crypto/conv.go 23.07% 10 Missing ⚠️
sei-tendermint/test/e2e/app/app.go 0.00% 4 Missing ⚠️
sei-tendermint/abci/tests/server/client.go 0.00% 3 Missing ⚠️
sei-cosmos/x/simulation/mock_tendermint.go 0.00% 2 Missing ⚠️
sei-tendermint/abci/types/types.go 0.00% 2 Missing ⚠️
sei-tendermint/crypto/ed25519/ed25519.go 90.00% 1 Missing and 1 partial ⚠️
sei-tendermint/internal/p2p/conn/connection.go 87.50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2650      +/-   ##
==========================================
- Coverage   42.01%   41.98%   -0.04%     
==========================================
  Files        1018     1017       -1     
  Lines       84809    84784      -25     
==========================================
- Hits        35636    35596      -40     
- Misses      45834    45849      +15     
  Partials     3339     3339              
Flag Coverage Δ
sei-cosmos 38.20% <0.00%> (ø)
sei-db 69.06% <ø> (ø)
sei-tendermint 47.27% <78.94%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-tendermint/internal/p2p/pex/reactor.go 89.24% <100.00%> (ø)
sei-tendermint/internal/p2p/transport.go 69.71% <100.00%> (ø)
sei-tendermint/internal/state/execution.go 61.47% <100.00%> (ø)
sei-tendermint/privval/grpc/client.go 50.00% <100.00%> (ø)
sei-tendermint/privval/grpc/server.go 100.00% <100.00%> (ø)
sei-tendermint/privval/signer_client.go 58.06% <100.00%> (+1.14%) ⬆️
sei-tendermint/privval/signer_requestHandler.go 55.55% <100.00%> (ø)
sei-tendermint/types/protobuf.go 90.47% <100.00%> (ø)
sei-tendermint/internal/p2p/conn/connection.go 81.99% <87.50%> (ø)
sei-cosmos/x/simulation/mock_tendermint.go 0.00% <0.00%> (ø)
... and 7 more

... and 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

if counter == math.MaxUint64 {
// Terminates the session and makes sure the nonce would not re-used.
// See https://github.com/tendermint/tendermint/issues/3531
panic("can't increase nonce without overflow")

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
return n, err
}
return n, err
panic("unreachable")

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants