-
Notifications
You must be signed in to change notification settings - Fork 2
fix(cli): remove minio environment variables from local instance #1507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The local instance configuration no longer sets SETTLEMINT_MINIO_* environment variables, preventing the CLI from installing @settlemint/sdk-minio when using --instance=local. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
PR SummaryRemoves MinIO configuration from the local connect flow to avoid triggering MinIO-specific behavior during local setups.
Written by Cursor Bugbot for commit cf0ccb7. This will update automatically on new commits. Configure here. |
Summary of ChangesHello @roderik, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue in the CLI's local instance connection process. By removing specific MinIO-related environment variables from the local configuration, the change ensures that the CLI no longer attempts to install the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
To view in Slack, search for: 1767427003.720549 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly removes MinIO-related environment variables from the configuration for a local instance. This change prevents the unnecessary installation of the @settlemint/sdk-minio package and also removes hardcoded credentials, which is a good security practice. The implementation is straightforward and effectively achieves the stated goal. The code looks good, and I have no further suggestions.
📝 WalkthroughWalkthroughThree MinIO-related environment variables are removed from the local connect flow in the connect command module. The removed variables are SETTLEMINT\_MINIO\_ACCESS\_KEY, SETTLEMINT\_MINIO\_ENDPOINT, and SETTLEMINT\_MINIO\_SECRET\_KEY. The change does not alter any control flow logic or exported public entities. Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📦 Packages
|
Summary
Removed SETTLEMINT_MINIO_* environment variables from the local instance configuration in the CLI connect command. This prevents the CLI from installing @settlemint/sdk-minio when using --instance=local.
🤖 Generated with Claude Code
Summary by cubic
Remove SETTLEMINT_MINIO_* env vars from the CLI connect command when using the local instance. This prevents installing @settlemint/sdk-minio and avoids unnecessary MinIO setup during local development.
Written for commit cf0ccb7. Summary will update on new commits.