Skip to content

Conversation

@roderik
Copy link
Member

@roderik roderik commented Jan 3, 2026

Summary

Removed SETTLEMINT_MINIO_* environment variables from the local instance configuration in the CLI connect command. This prevents the CLI from installing @settlemint/sdk-minio when using --instance=local.

🤖 Generated with Claude Code


Summary by cubic

Remove SETTLEMINT_MINIO_* env vars from the CLI connect command when using the local instance. This prevents installing @settlemint/sdk-minio and avoids unnecessary MinIO setup during local development.

Written for commit cf0ccb7. Summary will update on new commits.

The local instance configuration no longer sets SETTLEMINT_MINIO_* environment variables, preventing the CLI from installing @settlemint/sdk-minio when using --instance=local.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@cursor
Copy link

cursor bot commented Jan 3, 2026

PR Summary

Removes MinIO configuration from the local connect flow to avoid triggering MinIO-specific behavior during local setups.

  • In connectToLocal, stop writing SETTLEMINT_MINIO_ENDPOINT, SETTLEMINT_MINIO_ACCESS_KEY, and SETTLEMINT_MINIO_SECRET_KEY
  • Local config still sets SETTLEMINT_IPFS_API_ENDPOINT, SETTLEMINT_PORTAL_GRAPHQL_ENDPOINT, and The Graph defaults

Written by Cursor Bugbot for commit cf0ccb7. This will update automatically on new commits. Configure here.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @roderik, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue in the CLI's local instance connection process. By removing specific MinIO-related environment variables from the local configuration, the change ensures that the CLI no longer attempts to install the @settlemint/sdk-minio package unnecessarily when users connect to a local development environment. This improves the efficiency and correctness of the local setup.

Highlights

  • MinIO Environment Variables: Removed SETTLEMINT_MINIO_ACCESS_KEY, SETTLEMINT_MINIO_ENDPOINT, and SETTLEMINT_MINIO_SECRET_KEY from the local instance configuration within the connectToLocal function.
  • SDK Installation Prevention: This modification prevents the CLI from attempting to install the @settlemint/sdk-minio package when connecting to a local instance using the --instance=local flag, streamlining the setup.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added the qa:running QA workflow is currently running label Jan 3, 2026
@github-actions
Copy link

github-actions bot commented Jan 3, 2026

To view in Slack, search for: 1767427003.720549

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes MinIO-related environment variables from the configuration for a local instance. This change prevents the unnecessary installation of the @settlemint/sdk-minio package and also removes hardcoded credentials, which is a good security practice. The implementation is straightforward and effectively achieves the stated goal. The code looks good, and I have no further suggestions.

@coderabbitai
Copy link

coderabbitai bot commented Jan 3, 2026

📝 Walkthrough

Walkthrough

Three MinIO-related environment variables are removed from the local connect flow in the connect command module. The removed variables are SETTLEMINT\_MINIO\_ACCESS\_KEY, SETTLEMINT\_MINIO\_ENDPOINT, and SETTLEMINT\_MINIO\_SECRET\_KEY. The change does not alter any control flow logic or exported public entities.

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing MinIO environment variables from the local instance configuration in the CLI.
Description check ✅ Passed The description is directly related to the changeset, explaining why the MinIO environment variables were removed and the impact on SDK installation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between de7b5d9 and cf0ccb7.

📒 Files selected for processing (1)
  • sdk/cli/src/commands/connect.ts
💤 Files with no reviewable changes (1)
  • sdk/cli/src/commands/connect.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: QA
  • GitHub Check: QA

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the status:ready-for-review Pull request is ready for review label Jan 3, 2026
@github-actions
Copy link

github-actions bot commented Jan 3, 2026

📦 Packages

Package NPM Docker
SDK Cli @settlemint/sdk-cli@2.6.11-prb1d435f2
SDK The Graph @settlemint/sdk-thegraph@2.6.11-prb1d435f2
SDK Portal @settlemint/sdk-portal@2.6.11-prb1d435f2
SDK Hasura @settlemint/sdk-hasura@2.6.11-prb1d435f2
SDK JS @settlemint/sdk-js@2.6.11-prb1d435f2
SDK Utils @settlemint/sdk-utils@2.6.11-prb1d435f2
SDK Next @settlemint/sdk-next@2.6.11-prb1d435f2
SDK Minio @settlemint/sdk-minio@2.6.11-prb1d435f2
SDK IPFS @settlemint/sdk-ipfs@2.6.11-prb1d435f2
SDK Blockscout @settlemint/sdk-blockscout@2.6.11-prb1d435f2
SDK MCP @settlemint/sdk-mcp@2.6.11-prb1d435f2
SDK Viem @settlemint/sdk-viem@2.6.11-prb1d435f2
SDK EAS @settlemint/sdk-eas@2.6.11-prb1d435f2

@github-actions github-actions bot added qa:success QA workflow passed successfully fix Bug fix qa:failed QA workflow failed and removed qa:running QA workflow is currently running qa:success QA workflow passed successfully labels Jan 3, 2026
@roderik roderik merged commit 759f166 into main Jan 3, 2026
14 checks passed
@roderik roderik deleted the roderik/remove-local-minio-env branch January 3, 2026 08:07
@github-actions github-actions bot added status:merged Pull request has been merged and removed status:ready-for-review Pull request is ready for review labels Jan 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Bug fix qa:failed QA workflow failed status:merged Pull request has been merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants