Test groupmod -u with user list #1450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandro-colomar
changed the title
hallyn
approved these changes
Dec 29, 2025
Member
hallyn
left a comment
hallyn
left a comment
There was a problem hiding this comment.
Agreed with alx, a bit more explanation on patch 1 would be appreciated.
ikerexxe
force-pushed
the
test-groupmod-u
branch
2 times, most recently
from
6a1426d to
99abadd
Compare
GShadowEntry administrators and members represent a list of usernames, not a single string. Thus, set them to `list[str]`. This fixes type safety and clarifies the expected data structure. Fixes: 458700b (2025-09-10; "tests/system/framework/: fix Python linter issues") Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
…er list Add comprehensive test for the groupmod -U option when provided with a list of users to set group membership. This test verifies: - Setting initial group membership with multiple users - Proper membership verification in both group and gshadow entries - Updating group membership by modifying the user list - Correct handling of membership changes in group databases Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
ikerexxe
force-pushed
the
test-groupmod-u
branch
from
99abadd to
1ad1d8c
Compare
Collaborator
Author
|
I discovered an additional problem with |
hallyn
approved these changes
Dec 29, 2025
Member
|
@alejandro-colomar you ok with merging this before the release, or will that throw a wrench into testing you've already done? |
Collaborator
I'm okay with it. :) |
alejandro-colomar
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comprehensive test for the groupmod -U option when provided with a
list of users to set group membership. This test verifies: