Skip to content

Conversation

@riley-ball
Copy link

This repository contains the code for the Improved U-Net model for the ISIC 2018 Skin Lesion Segmentation dataset (https://challenge.isic-archive.com/data/#2018). Contains the following files:

  • “modules.py" containing the source code of the components of your model where each componented is implemented as functions
  • “dataset.py" containing the data loader for loading and preprocessing the data
  • “train.py" containing the source code for training, validating, testing and saving your model.
  • “predict.py" showing example usage of the trained model.

Riley Ball | 45293915

riley-ball and others added 30 commits October 20, 2023 00:15
@wangzhaomxy
Copy link
Collaborator

wangzhaomxy commented Nov 6, 2023

This is an initial inspection, no action is required at this point

  • Well organized files.
  • Algorithm solves the problem appropriately. Average Dice Coefficient in testing dataset: 0.81. Very good output.
  • Correctly using TensorFlow to construct the Improved U-Net models and functions.
  • Good coding design.
  • Sufficient docstring and comment in the code.
  • Easy difficulty problem, no higher difficulty marks.

@shakes76 shakes76 added the Extension Extension approved label Nov 20, 2023
@shakes76
Copy link
Owner

Marking

Good Practice (Design/Commenting, TF/Torch Usage)

Adequate design and implementation
Good spacing and comments
Header blocks missing -1

Recognition Problem

Solves problem
Driver Script present
File structure present
Shows Usage & Demo & Visualisation & Data usage
Module present
Commenting
No Data leakage
Difficulty: Easy -10

Commit Log

Meaningful commit messages
Progressive commits used

Documentation

ReadMe acceptable, missing refs -1
Model/technical explanation
Good Description and Comments
Markdown used and PDF submitted

Pull Request

Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch)
No Feedback required
Request Description good

@shakes76
Copy link
Owner

Please revert changes to repo README files for merging, does not affect grade only merge.

@shakes76 shakes76 added the question Further information is requested label Nov 20, 2023
@riley-ball
Copy link
Author

Please revert changes to repo README files for merging, does not affect grade only merge.

Sorry a bit confused, which README file is this in relation to and which changes? (did I modify a README I wasn't supposed to or is this in relation to the README that documents my model?)

@wangzhaomxy
Copy link
Collaborator

Please revert changes to repo README files for merging, does not affect grade only merge.

Sorry a bit confused, which README file is this in relation to and which changes? (did I modify a README I wasn't supposed to or is this in relation to the README that documents my model?)

You shouldn't modify the original ReadMe.md files when you first fork Shakes' repository. All student-constructed folders/files, including your own Readme.md for your project, should be packed in one folder under the ‘recognition’ folder. So you need to recover the original README file and move your own readme file into your own folder.

@wangzhaomxy
Copy link
Collaborator

No feedback attempt and no feedback marks lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Extension Extension approved Improved UNet question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants