Skip to content

Conversation

@pranaypremdas
Copy link

@pranaypremdas pranaypremdas commented Oct 21, 2022

Created pull request for the algorithm implemented. This pull request attempts to solve Task 6 of the report. Student Number: 46444675, Pranay Premdas

@pranaypremdas pranaypremdas reopened this Oct 21, 2022
@pranaypremdas
Copy link
Author

Hi, I seem to have forgotten to add two changes in my code I hope this does not affect my mark.

  1. Changing the epochs to 50 - I was experimenting with the plots and forgot to change it back to 50
  2. Adding plt.legend(loc='lower right') in the plots for accuracy and loss. I was working on my cluster copy and forgot to copy it over to the local one used for pushing code.

@LinfengLiu98
Copy link
Collaborator

This is an initial inspection, no action is required at this point

There is no README file provided which you will need to explain your model and present your results.

Commit log: Great

@pranaypremdas
Copy link
Author

This is an initial inspection, no action is required at this point

There is no README file provided which you will need to explain your model and present your results.

Commit log: Great

HI, I seem to have forgotten to upload the read me on here. I have however submitted it on blackboard. I hope this does not affect my mark. To make it easier I have pushed the read me on here.

@LinfengLiu98
Copy link
Collaborator

This is an initial inspection, no action is required at this point
There is no README file provided which you will need to explain your model and present your results.
Commit log: Great

HI, I seem to have forgotten to upload the read me on here. I have however submitted it on blackboard. I hope this does not affect my mark. To make it easier I have pushed the read me on here.

All good, I can see it now. :)

@shakes76
Copy link
Owner

Good Practice (Design/Commenting, TF/Torch Usage)

Adequate use and implementation
Good spacing and comments
Header blocks missing -1

Recognition Problem

Solves problem (low performance) -1
Driver Script present
File structure present
Shows Usage & Demo & Visualisation & Data usage
Module present
Commenting
No Data leakage
Difficulty: Hard

Commit Log

Meaningful commit messages
Progressive commits used

Documentation

ReadMe OK, but needs architecture diagram and more info/background -2
Good Description and Comments
Markdown used PDF submitted

Pull Request

Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch)
Feedback required, rename your folder to something unique (add ID or equivalent) otherwise it will clash with other students -2
Request Description minimal, needs more info -2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants