[Demo] Multi order diffraction #95

singer-yang · 2025-12-31T12:26:12Z

Add a tutorial demo to visualize multi-order diffraction
Refactor diffractive surface functions

cursor · 2025-12-31T12:26:16Z

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on January 7.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Copilot

Pull request overview

This PR adds a multi-order diffraction visualization demo and refactors diffractive surface functions for improved code organization and extensibility. The changes introduce a new Grating DOE class for simulating linear grating diffraction patterns and standardize the API across all diffractive optical elements.

Key changes:

Adds a new Grating diffractive optical element for linear grating patterns with configurable angle and phase gradient strength
Refactors diffractive surface methods by renaming _phase_map0() to phase_func() and introducing quantization support via a new diff_quantize autograd function
Adds fab_step parameter across all DOE classes for better fabrication control

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
deeplens/optics/utils.py	Adds `diff_quantize` autograd function for differentiable quantization using Straight-Through Estimator; removes unused `torch.nn` import
deeplens/optics/diffractive_surface/diffractive.py	Refactors phase calculation methods (`_phase_map0()` → `phase_func()`), adds `fab_step` parameter, integrates quantization, simplifies visualization methods, and marks computed fields with parentheses in `surf_dict()`
deeplens/optics/diffractive_surface/grating.py	New Grating DOE class implementing linear phase gradient for multi-order diffraction with configurable angle (theta) and gradient strength (alpha)
deeplens/optics/diffractive_surface/zernike.py	Updates to use new `phase_func()` method, adds `fab_step` parameter, and refactors `init_from_dict()` for cleaner parameter handling
deeplens/optics/diffractive_surface/thinlens.py	Updates to use new `phase_func()` method, adds `fab_step` parameter, and refactors `init_from_dict()`
deeplens/optics/diffractive_surface/pixel2d.py	Updates to use new `phase_func()` method, adds `fab_step` parameter, and refactors `init_from_dict()`
deeplens/optics/diffractive_surface/fresnel.py	Updates to use new `phase_func()` method, adds `fab_step` parameter, and refactors `init_from_dict()`
deeplens/optics/diffractive_surface/binary2.py	Updates to use new `phase_func()` method, adds `fab_step` parameter, and refactors `init_from_dict()`
deeplens/optics/diffractive_surface/init.py	Adds Grating to module exports
deeplens/hybridlens.py	Adds support for loading Grating DOE from JSON configuration using "type" field instead of "param_model"
datasets/lenses/hybridlens/a489_grating.json	Configuration file for A489 lens with linear grating DOE for multi-order diffraction demonstrations
8_multi_order_diffraction.py	Demo script visualizing multi-order diffraction PSF patterns from a hybrid lens with grating, showing both linear and log-scale plots for multiple wavelengths

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-31T12:31:12Z

deeplens/hybridlens.py

+                doe = Grating.init_from_dict(doe_dict)
            else:
                raise ValueError(
                    f"Unsupported DOE parameter model: {doe_dict['param_model']}"


The error message references 'doe_dict["param_model"]' but the code now uses 'doe_dict["type"]' (line 77). The error message should be updated to reference the correct dictionary key for consistency.

Suggested change

f"Unsupported DOE parameter model: {doe_dict['param_model']}"

f"Unsupported DOE parameter model: {doe_param_model}"

Copilot · 2025-12-31T12:31:13Z

deeplens/optics/diffractive_surface/thinlens.py

+            fab_step=doe_dict.get("fab_step", 16),
        )

    def get_phase_map(self, wvln=0.55):


The ThinLens.get_phase_map method has a default parameter value 'wvln=0.55', but the parent class DiffractiveSurface.get_phase_map now requires 'wvln' without a default. This creates an inconsistency in the API. Either remove the default from ThinLens to match the parent class signature, or add it back to the parent class if a default is desired.

Suggested change

def get_phase_map(self, wvln=0.55):

def get_phase_map(self, wvln):

Copilot · 2025-12-31T12:31:13Z

deeplens/optics/utils.py

+    @staticmethod
+    def forward(ctx, x, levels, interval=2 * torch.pi):
+        step = interval / levels
+        ctx.step = step


The variable 'ctx.step' is saved in the forward pass but never used in the backward pass. Since the Straight-Through Estimator simply passes gradients through unchanged, this variable can be removed to avoid unnecessary state storage.

Suggested change

ctx.step = step

Copilot · 2025-12-31T12:31:13Z

deeplens/optics/diffractive_surface/grating.py

+        self.theta = torch.tensor(theta)  # angle from y-axis to grating vector
+        self.alpha = torch.tensor(alpha)  # slope of the grating


The tensors for theta and alpha are created without specifying the device parameter, then the object is moved to device later with self.to(device). For consistency and to avoid potential device mismatch issues, these tensors should be created with the device parameter directly: torch.tensor(theta, device=device).

Suggested change

self.theta = torch.tensor(theta) # angle from y-axis to grating vector

self.alpha = torch.tensor(alpha) # slope of the grating

self.theta = torch.tensor(theta, device=device) # angle from y-axis to grating vector

self.alpha = torch.tensor(alpha, device=device) # slope of the grating

Copilot · 2025-12-31T12:31:13Z

8_multi_order_diffraction.py

+        axes[0].axvline(
+            x=len(psf_center) // 2,
+            color="red",
+            linestyle="--",
+            alpha=0.5,
+            label="Center",
+        )


The axvline is created with a label="Center" parameter after the legend has already been created (line 50). This means the "Center" label will not appear in the legend. Either remove the label parameter from axvline (since it's self-explanatory as a visual guide), or move the legend() call to after the axvline if the label should be included in the legend.

Copilot · 2025-12-31T12:31:14Z

8_multi_order_diffraction.py

+        axes[1].axvline(
+            x=len(psf_center) // 2,
+            color="red",
+            linestyle="--",
+            alpha=0.5,
+            label="Center",
+        )


The axvline is created with a label="Center" parameter after the legend has already been created (line 71). This means the "Center" label will not appear in the legend. Either remove the label parameter from axvline (since it's self-explanatory as a visual guide), or move the legend() call to after the axvline if the label should be included in the legend.

Copilot · 2025-12-31T12:31:14Z

deeplens/optics/diffractive_surface/__init__.py

 from .zernike import Zernike

-__all__ = ["DOE", "Fresnel", "Pixel2D", "ThinLens", "Zernike", "Binary2"]
+__all__ = ["DOE", "Fresnel", "Grating", "Pixel2D", "ThinLens", "Zernike", "Binary2"]


The name 'DOE' is exported by all but is not defined.

Suggested change

__all__ = ["DOE", "Fresnel", "Grating", "Pixel2D", "ThinLens", "Zernike", "Binary2"]

__all__ = ["DiffractiveSurface", "Fresnel", "Grating", "Pixel2D", "ThinLens", "Zernike", "Binary2"]

singer-yang added 6 commits December 30, 2025 23:29

add, grating DOE

002f088

add, multi-order diffraction with grating hybrid lens

d3d2619

refactor, diffractive surf IO

295e779

add, differentiable quantize func

cabe0f8

fix, mutli order diffraction demo code

4484d34

rename

df8c4a4

singer-yang requested a review from Copilot December 31, 2025 12:26

Copilot started reviewing on behalf of singer-yang December 31, 2025 12:26 View session

Copilot AI reviewed Dec 31, 2025

View reviewed changes

fix, minor bugs found by copilot

0d1da10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[Demo] Multi order diffraction #95

[Demo] Multi order diffraction #95

Uh oh!

singer-yang commented Dec 31, 2025

Uh oh!

cursor bot commented Dec 31, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 31, 2025

Uh oh!

Copilot AI Dec 31, 2025

Uh oh!

Copilot AI Dec 31, 2025

Uh oh!

Copilot AI Dec 31, 2025

Uh oh!

Copilot AI Dec 31, 2025

Uh oh!

Copilot AI Dec 31, 2025

Uh oh!

Copilot AI Dec 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	f"Unsupported DOE parameter model: {doe_dict['param_model']}"
	f"Unsupported DOE parameter model: {doe_param_model}"

	def get_phase_map(self, wvln=0.55):
	def get_phase_map(self, wvln):

		self.theta = torch.tensor(theta) # angle from y-axis to grating vector
		self.alpha = torch.tensor(alpha) # slope of the grating

	__all__ = ["DOE", "Fresnel", "Grating", "Pixel2D", "ThinLens", "Zernike", "Binary2"]
	__all__ = ["DiffractiveSurface", "Fresnel", "Grating", "Pixel2D", "ThinLens", "Zernike", "Binary2"]

Uh oh!

[Demo] Multi order diffraction #95

Are you sure you want to change the base?

[Demo] Multi order diffraction #95

Uh oh!

Conversation

singer-yang commented Dec 31, 2025

Uh oh!

cursor bot commented Dec 31, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants