Various visualization fixes #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to place the arrows inside of the visualization div instead of the body element. The arrows won't overlap any longer with the UI controls at the bottom. Also, the position of the arrows does not need to be updated any longer on every scroll event.
skogsbaer
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the lines/arrows, I switched to the LinkerLine library. It's an extension of the original LeaderLine library (which is seemingly no longer maintained). It isn't really widely used but I think it should serve the purpose for us (placing the lines inside of the visualization div).
Resolves #142
The error handling is now also improved. Previously, return steps (originating from throwing the exception) were also displayed. This is no longer the case.
Resolves #144