Skip to content

Conversation

@winder
Copy link
Collaborator

@winder winder commented Dec 19, 2025

  • Add testing.Short() check to tests that use docker. This speeds up unit tests on my local machine so that they run in 45 seconds.
  • Re-introduce the codecov script, it is new and improved with a diff column.
  • Apply the test filter to the target branch. This is what previously caused incorrect coverage numbers on the main branch.

Note: The report in thie PR has some minor discrepancy because -short is not yet used in main.

@winder winder force-pushed the will/test-coverage-report branch from 4bfc6fc to fb25832 Compare December 19, 2025 16:59
@winder winder marked this pull request as ready for review December 19, 2025 19:20
@winder winder requested review from a team and skudasov as code owners December 19, 2025 19:20
@winder winder changed the title Will/test coverage report Unit test coverage report. Dec 19, 2025
@winder winder enabled auto-merge December 19, 2025 21:41
Comment on lines +54 to +62
# TODO: enable after available on base branch.
# just test-coverage coverage_file=coverage_target.out short
go test -shuffle on -v -short -coverprofile=coverage_target.out ./...
go test -v -race -fullpath -shuffle on -short -coverprofile=coverage_target.out ./...
# Filter mockery-generated files (mock_*.go) from coverage profile
{ head -n1 coverage_target.out; tail -n +2 coverage_target.out | grep -v -E '(/mock_.*\.go:|/_mocks/.*:|/mocks/.*:)' || true; } > coverage_target.out.filtered
mv coverage_target.out.filtered coverage_target.out
# TODO: replace until here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is replaced by just test-coverage coverage_file=coverage_target.out short after the "short" option is available upstream.

@winder winder force-pushed the will/test-coverage-report branch from 1b89673 to 994ed70 Compare January 5, 2026 14:05
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Code coverage report:

Package main will/test-coverage-report diff
github.com/smartcontractkit/chainlink-ccv/aggregator 37.60% 28.30% -9.30%
github.com/smartcontractkit/chainlink-ccv/cmd 0.00% 0.00% +0.00%
github.com/smartcontractkit/chainlink-ccv/committee 100.00% 100.00% +0.00%
github.com/smartcontractkit/chainlink-ccv/common 0.00% 0.00% +0.00%
github.com/smartcontractkit/chainlink-ccv/executor 49.41% 49.41% +0.00%
github.com/smartcontractkit/chainlink-ccv/indexer 22.51% 22.51% +0.00%
github.com/smartcontractkit/chainlink-ccv/integration 42.40% 42.40% +0.00%
github.com/smartcontractkit/chainlink-ccv/pkg 100.00% 100.00% +0.00%
github.com/smartcontractkit/chainlink-ccv/protocol 51.39% 51.39% +0.00%
github.com/smartcontractkit/chainlink-ccv/verifier 59.92% 58.15% -1.77%

@winder winder added this pull request to the merge queue Jan 5, 2026
Merged via the queue into main with commit 5bd9cbf Jan 5, 2026
17 of 18 checks passed
@winder winder deleted the will/test-coverage-report branch January 5, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants