change aptos operation to untyped relax #20688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FelixFan1992
requested review from
0xAustinWang,
agusaldasoro,
b-gopalswami,
chris-de-leon-cll,
makramkd,
mateusz-sekara,
rodrigombsoares and
winder
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates all Aptos operation definitions to use AsUntypedRelaxed() instead of AsUntyped() for type conversion. This change appears to be part of a broader API modification to relax type constraints when converting typed operations to untyped ones.
Key Changes:
- Replaced all
.AsUntyped()calls with.AsUntypedRelaxed()across operation definitions - Applied consistently across all Aptos CCIP operation files
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| deployment/ccip/changeset/aptos/operation/token_pool.go | Updated 7 token pool operations to use relaxed untyped conversion |
| deployment/ccip/changeset/aptos/operation/token_admin_registry.go | Updated 3 token admin registry operations to use relaxed untyped conversion |
| deployment/ccip/changeset/aptos/operation/token.go | Updated 12 token-related operations to use relaxed untyped conversion |
| deployment/ccip/changeset/aptos/operation/router.go | Updated router operation to use relaxed untyped conversion |
| deployment/ccip/changeset/aptos/operation/registry.go | Updated curse/uncurse operations to use relaxed untyped conversion |
| deployment/ccip/changeset/aptos/operation/on_ramp.go | Updated on-ramp operation to use relaxed untyped conversion |
| deployment/ccip/changeset/aptos/operation/off_ramp.go | Updated 2 off-ramp operations to use relaxed untyped conversion |
| deployment/ccip/changeset/aptos/operation/mcms.go | Updated 3 MCMS operations to use relaxed untyped conversion |
| deployment/ccip/changeset/aptos/operation/fee_quoter.go | Updated 4 fee quoter operations to use relaxed untyped conversion |
| deployment/ccip/changeset/aptos/operation/ccip.go | Updated 5 CCIP core operations to use relaxed untyped conversion |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
graham-chainlink
approved these changes
Dec 29, 2025
anirudhwarrier
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Supports