Skip to content

Conversation

@liondedan
Copy link
Contributor

We want our a href tags to have consistent styling both on pages that we
develop and when used by content editors on html

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which improves functionality or refactors code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

We want our a href tags to have consistent styling both on pages that we
develop and when used by content editors on html
@liondedan liondedan requested a review from bitscraps September 29, 2020 11:20
@liondedan liondedan self-assigned this Sep 29, 2020
color: ${theme.colors.primary}
}
a:link, a:visited {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about hover and focus? It's key for accessibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants