Skip to content

Conversation

@recursiveKirs
Copy link
Contributor

@recursiveKirs recursiveKirs commented Nov 22, 2021

Description

The Select component handles the text input state internally, however, we need to hoist that up so that the consumer can implement Lazy Loading and Debouncing of the input. This is done via the optional controlledInputStateValue prop which is the state and setState from a useState call.

Motivation and Context

Allows consumers to control the input state.

Types of changes

  • [X ] New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which improves functionality or refactors code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ X] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • [ X] All new and existing tests passed.

@recursiveKirs recursiveKirs changed the title FX-1895 update select component for lazy loading FX-1895 Allow for the Select component to be a controlled input Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants