Skip to content

Conversation

@mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Jun 18, 2025

Summary

Moves some classes to become anonymous classes. Fixes a Rubocop offense. Extracted from #6287

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@mamhoff mamhoff requested a review from a team as a code owner June 18, 2025 11:35
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Jun 18, 2025
@codecov
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.95%. Comparing base (a2a55d6) to head (80fd096).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6289   +/-   ##
=======================================
  Coverage   88.95%   88.95%           
=======================================
  Files         860      860           
  Lines       18423    18423           
=======================================
  Hits        16388    16388           
  Misses       2035     2035           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase

It's actually not great to define classes in tests.
@mamhoff mamhoff force-pushed the fix-calculator-spec-rubocop branch from 1826cfa to 80fd096 Compare June 18, 2025 12:18
@tvdeyen tvdeyen merged commit 1061e56 into solidusio:main Jun 18, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_core Changes to the solidus_core gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants