Move LoadPromotions out of OrderAdjuster namespace #6292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_promotions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6292 +/- ##
==========================================
+ Coverage 86.65% 88.98% +2.32%
==========================================
Files 521 863 +342
Lines 11943 18425 +6482
==========================================
+ Hits 10349 16395 +6046
- Misses 1594 2030 +436 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mamhoff
force-pushed
the
move-load-promotions-out-of-order-adjuster
branch
from
3a71ad2 to
ca2b096
Compare
Loading the currently available promotions can be quite useful outside of the order adjuster. This moves the LoadPromotions class out of there and into the main `SolidusPromotions` namespace so that it's clear that this class can be used elsewhere.
mamhoff
force-pushed
the
move-load-promotions-out-of-order-adjuster
branch
from
ca2b096 to
987fd44
Compare
github-project-automation
bot
moved this from In Progress
to Done
in Solidus Public Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Loading the currently available promotions can be quite useful outside of the order adjuster. This moves the LoadPromotions class out of there and into the main
SolidusPromotionsnamespace so that it's clear that this class can be used elsewhere.Extracted from #6287
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: