Skip to content

Conversation

@tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jan 4, 2026

Summary

Needs solidusio/test-solidus-extension#3

Instead of setting up all services and the matrix
in this extension we use the new reusable workflow
that handles this for us.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@tvdeyen tvdeyen force-pushed the use-reusable-workflow-for-ci branch 5 times, most recently from 402ba25 to 6c352de Compare January 4, 2026 21:09
@mamhoff
Copy link
Contributor

mamhoff commented Jan 5, 2026

Have a look at the Gemfile as well - I think we're not adding the necessary ~> before the Rails version.

Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

Instead of setting up all services and the matrix
in this extension we use the new reusable workflow
that handles this for us.

Needs solidusio/test-solidus-extension#3
@tvdeyen tvdeyen force-pushed the use-reusable-workflow-for-ci branch from 272cbe6 to fea426a Compare January 5, 2026 11:28
@tvdeyen tvdeyen merged commit c73f10f into main Jan 5, 2026
12 checks passed
@tvdeyen tvdeyen deleted the use-reusable-workflow-for-ci branch January 5, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants