fix: Testing database adapters #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Tested with solidusio/solidus_auth_devise#267 |
tvdeyen
changed the title
tvdeyen
force-pushed
the
support-testings-dbs
branch
3 times, most recently
from
7987635 to
3ace621
Compare
tvdeyen
force-pushed
the
support-testings-dbs
branch
5 times, most recently
from
c854be9 to
69c4741
Compare
Member
Author
|
Finally works solidusio/solidus_auth_devise#267 😓 |
tvdeyen
force-pushed
the
support-testings-dbs
branch
2 times, most recently
from
c4f1942 to
7d5bd28
Compare
GitHub composite actions do not support starting services. The calling workflow needs to handle this. Currently all our extensions that test multiple database actually test with SQLite all the time. Expose necessary ENV vars for testing MySQL and PostgreSQL on GitHub actions. Adding examples and more documentation to README. We now need to update all extensions that use this action manually
tvdeyen
force-pushed
the
support-testings-dbs
branch
from
7d5bd28 to
be8d5ac
Compare
5 tasks
mamhoff
reviewed
Jan 5, 2026
| Configure your database services with passwordless access for simplicity (see example below). | ||
|
|
||
| > [!WARNING] | ||
| > Rails 8.0 has a [known issue](https://github.com/rails/rails/issues/53673) with MySQL/MariaDB that causes empty `Mysql2::Error` messages. Until a fix is released, exclude the `mariadb` + Rails 8.0 combination from your test matrix. |
Contributor
There was a problem hiding this comment.
It appears this is fixed in Rails 8.0.1+. See rails/rails@12e4394
mamhoff
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GitHub composite actions do not
support starting services. The calling
workflow needs to handle this.
Currently all our extensions that test
multiple database actually test with
SQLite all the time.
Expose necessary ENV vars for testing
MySQL and PostgreSQL on GitHub actions.
Adding examples and more documentation
to README. We now need to update all
extensions that use this action manually
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: