Non-ascii file tree bug #726
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git quotes paths containing non-ASCII characters using octal escape sequences (e.g., "src/\321\202\320\265\321\201\321\202.txt"). The previous code split on comma, leaving quotes in the path, which caused folders like "src" to appear twice (once as "src" and once as '"src'). Fixed by adding -c core.quotePath=false to all git ls-tree commands, which outputs paths without quoting, preventing duplicate folder entries. Fixes #SOU-74
|
Cursor Agent can help with this pull request. Just |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes duplicate folders in the file tree caused by non-ASCII characters in file paths.
Git was quoting non-ASCII characters in file paths with octal escape sequences (e.g.,
"src/\321\202\320\265\321\201\321\202.txt"). The existing parsing logic would then treat"src(with a leading quote) as a distinct folder fromsrc, leading to duplicates. This PR adds-c core.quotePath=falsetogit ls-treecommands to prevent Git from quoting these paths.Linear Issue: SOU-74