feat(mcp): only set variables for set flags #1234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we had code which tried to detect nil values. But for example if a flag is an integer that wouldn't work. Instead we use a more robust approach of only setting variables if the flag was passed in as an argument. Test Plan: this command actually returns results now. Previously it wouldn't since it would have limit set to 0. go run ./cmd/src -v mcp list-repos -query 'cloud'
burmudar
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had code which tried to detect nil values. But for example if a flag is an integer that wouldn't work. Instead we use a more robust approach of only setting variables if the flag was passed in as an argument.
Test Plan: this command actually returns results now. Previously it wouldn't since it would have limit set to 0.
go run ./cmd/src -v mcp list-repos -query 'cloud'