Skip to content

fix/code review issues #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
damacus wants to merge 6 commits into from
Closed

fix/code review issues #749

damacus wants to merge 6 commits into from

Conversation

@damacus
Copy link
Member

@damacus damacus commented Jan 7, 2026

  • fix: remove duplicate action and action_class blocks in alternatives.rb
  • Fix code errors
  • docs: update code-review-agent workflow for Chef cookbooks
  • docs: use fish heredoc for multiline git commits in workflow

damacus added 4 commits January 7, 2026 23:06
@damacus
fix: remove duplicate action and action_class blocks in alternatives.rb
aa3c820 
The file had duplicate definitions of action :unset (lines 38-44 and 136-142)
and action_class (lines 46-134 and 144-148). The second definitions would
override the first, causing parse_java_alternatives and set_alternatives
methods to be lost.
@damacus
Fix code errors
f6e6311 
Signed-off-by: Dan Webb <dan.webb@damacus.io>
@damacus
docs: update code-review-agent workflow for Chef cookbooks
2b5cc05
@damacus
docs: use fish heredoc for multiline git commits in workflow
a43e7e5
@damacus damacus requested a review from a team as a code owner January 7, 2026 23:11
@damacus damacus force-pushed the fix/code-review-issues branch from 7a4fb8d to bb92fe5 Compare January 7, 2026 23:17
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Slowest examples

Top 10 slowest examples (0.02 seconds, 73.48% of total time)
Example Description Time in seconds
spec/libraries/certificate_helpers_spec.rb:15 Java::Cookbook::CertificateHelpers#default_truststore_path Java 9 returns the correct path 0.01357
spec/libraries/corretto_helpers_spec.rb:79 Java::Cookbook::CorrettoHelpers#default_bin_cmds Corretto 11 returns the correct bin command array 0.00653
spec/libraries/corretto_helpers_spec.rb:20 Java::Cookbook::CorrettoHelpers#default_corretto_url Corretto 11 x64 returns the correct URL 0.00353
spec/libraries/corretto_helpers_spec.rb:29 Java::Cookbook::CorrettoHelpers#default_corretto_url Corretto 17 x64 returns the correct URL 0.00049
spec/libraries/corretto_helpers_spec.rb:140 Java::Cookbook::CorrettoHelpers#default_bin_cmds #corretto_sub_dir No full_version passed for Corretto 17 aarch64 returns the default directory value for Corrretto 17 aarch64 0.00049
spec/libraries/corretto_helpers_spec.rb:149 Java::Cookbook::CorrettoHelpers#default_bin_cmds #corretto_sub_dir No full_version passed for Corretto 18 x64 returns the default directory value for Corrretto 18 x64 0.00049
spec/libraries/corretto_helpers_spec.rb:122 Java::Cookbook::CorrettoHelpers#default_bin_cmds #corretto_sub_dir No full_version passed for Corretto 11 aarch64 returns the default directory value for Corrretto 11 aarch64 0.00047
spec/libraries/corretto_helpers_spec.rb:47 Java::Cookbook::CorrettoHelpers#default_corretto_url Corretto 11 aarch64 returns the correct URL 0.00046
spec/libraries/openjdk_helpers_spec.rb:32 Java::Cookbook::OpenJdkHelpers#default_openjdk_url Invalid OpenJDK version should raise an error 0.00046
spec/libraries/corretto_helpers_spec.rb:158 Java::Cookbook::CorrettoHelpers#default_bin_cmds #corretto_sub_dir No full_version passed for Corretto 18 aarch64 returns the default directory value for Corrretto 18 aarch64 0.00046

@damacus damacus enabled auto-merge (squash) January 8, 2026 08:59
@damacus damacus closed this Jan 8, 2026
auto-merge was automatically disabled January 8, 2026 09:26

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@damacus