Feat added overloads for encodeNonNullPassword and matchesNonNull for users who would prefer to avoid passing passwords as String #18360
+34
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… users who would prefer to avoid passing passwords as String Signed-off-by: PrittSpadeLord <pritt1999@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
Signed-off-by: PrittSpadeLord <pritt1999@gmail.com>
PrittSpadeLord
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
Argon2PasswordEncoder's methodsencodeNonNullPasswordandmatchesNonNullaccept onlyStringforrawPassword. Given thatStringis immutable in Java, it remains in memory until it is claimed by GC, and whether the GC zeroes out the data is also implementation-specific. This can be a security vulnerability prone to memory dumps exposing the password.As such, I have added overloads for these methods that take in
char[]directly. Users who wish to not allow passwords to linger on their JVM memory may use these methods and immediately follow it with aArrays.fill(rawPassword, '\0')to ensure passwords never linger in the machine's memory beyond its expected lifetime.