🛡️ Sentinel: Enforce max version string length (DoS prevention) #799
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛡️ Sentinel: [MEDIUM] Fix DoS risk via long input strings
Severity: MEDIUM
Vulnerability: The version comparison logic accepted strings of arbitrary length. Extremely long strings could cause CPU exhaustion or OOM due to internal string operations (
replace,split) and regex checks.Impact: Denial of Service (DoS) if user-supplied input is passed unchecked to the library.
Fix: Enforced a
MAX_VERSION_LENGTHof 256 characters. Inputs longer than this are immediately rejected (returnNaN), preserving existing fail-closed behavior.Verification: Added a test case in
src/security.test.tsverifying that a string of 300 characters is rejected.PR created automatically by Jules for task 4012677338304431508 started by @srod
Summary by cubic
Enforces a 256-character max for version strings to prevent DoS from extremely long inputs. Inputs over the limit now fail closed by returning NaN.
Written for commit f598875. Summary will update on new commits.