-
Notifications
You must be signed in to change notification settings - Fork 8
183: add a method to add file info to assets #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ping-e84
wants to merge
9
commits into
stac-utils:main
Choose a base branch
from
ping-e84:feature/183/add-fileinfo-to-assets
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
183: add a method to add file info to assets #200
ping-e84
wants to merge
9
commits into
stac-utils:main
from
ping-e84:feature/183/add-fileinfo-to-assets
+816
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjhartzell
requested changes
Jan 5, 2026
Collaborator
pjhartzell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a few questions
Collaborator
|
This PR also closes #154 |
add py-multihash dependency re-write compute_multihash method minor update to tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Proposed Changes:
add_fileinfo_to_local_assets(plural) is the expected primary user-facing function - for an Item, derives file size in bytes and checksum for all Assets with a local href.add_fileinfo_to_local_asset(singular) is called byadd_fileinfo_to_local_assetsas it loops through assets: this is (a) the workhorse method that adds the STAC file extension to the Item and metadata fields to each local asset. It supports all file extension fields, but, since most of the fields are not easily calculated on an automated basis, leaves it up to the user to calculate and pass in directly (only size and checksum are automated).compute_multihashcalculates file hash based on sha2-256 (but is flexible and allows for other supported algorithms to be used)._is_local_fileis a supporting method that allows the user-facing methods to add file metadata or not (if the asset href is non-local).PR Checklist:
Use of AI: