Skip to content

Conversation

@Alex-Welsh
Copy link
Member

2025.1 version of #2026

@jovial isn't around at the moment so picking this one up in his place

@Alex-Welsh Alex-Welsh requested a review from a team as a code owner January 7, 2026 10:33
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue with Prometheus blackbox exporter endpoint generation when the exporter and the Prometheus server are not located on the same host. The fix involves renaming an Ansible group variables file from prometheus-blackbox-exporter to prometheus, which correctly scopes the variables for the Prometheus server. A release note has also been added to document this change. The changes appear correct and effectively address the described problem.

@Alex-Welsh Alex-Welsh merged commit 32405b6 into stackhpc/2025.1 Jan 7, 2026
21 checks passed
@Alex-Welsh Alex-Welsh deleted the fix-blackbox-move branch January 7, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants