-
Notifications
You must be signed in to change notification settings - Fork 1
Skip keystone sync for master and yoga branches #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @priteau, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Ansible inventory configuration to include the 'yoga' OpenStack release in the list of managed source repositories. The primary purpose of this change is to facilitate an optimization where keystone synchronization can be skipped for the 'yoga' release, as there are no custom downstream patches present in the project's fork that would necessitate it. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the configuration to skip synchronizing the yoga release for the keystone repository by adding it to the ignored_releases list. The change is straightforward and correctly placed to maintain the alphabetical order of the release names in the list. The modification aligns with the pull request's stated goal, and I find no issues with it.
There are no downstream patches in our fork.
a00537b to
6720f9b
Compare
Alex-Welsh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future reference, the commit missing in epoxy upstream is 64b82bd048b7b64ce128cc27b7e964b2150f8499
This is being reviewed upstream as: https://review.opendev.org/c/openstack/keystone/+/972248 |
There are no downstream patches in our fork.