Skip to content

Conversation

@WardBrian
Copy link
Member

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

This closes #687 and #362, and cleans up a lot of the temp file code we currently have.

The actual test is guarded behind a version test due to this cmdstan bug, but locally I have confirmed the fix works

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@WardBrian WardBrian requested a review from mitzimorris August 28, 2023 16:28
@WardBrian WardBrian linked an issue Aug 28, 2023 that may be closed by this pull request
Copy link
Member

@mitzimorris mitzimorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2023

Codecov Report

Merging #688 (e27e387) into develop (7cf6483) will increase coverage by 0.25%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #688      +/-   ##
===========================================
+ Coverage    80.31%   80.56%   +0.25%     
===========================================
  Files           72       72              
  Lines        11265    11292      +27     
===========================================
+ Hits          9047     9097      +50     
+ Misses        2218     2195      -23     

see 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@WardBrian WardBrian merged commit 107a347 into develop Aug 28, 2023
@WardBrian WardBrian deleted the feature/multiple-inits branch August 28, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants