-
-
Notifications
You must be signed in to change notification settings - Fork 127
Documentation for the wiener cdf functions #924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
bob-carpenter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor comments on form and naming
src/functions-reference/positive_lower-bounded_distributions.qmd
Outdated
Show resolved
Hide resolved
| ## Wiener First Passage Time Distribution | ||
|
|
||
| For an explanation how to use the `wiener_lpdf` and `wiener_l[c]cdf_defective` functions, see | ||
| @Henrich2024 and @Henrich_inpress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not be citing things as "in press". That's not something anyone can find, so it's useless in doc. If there's an arXiv preprint we can cite that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Franzi2114 is there a preprint available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think one reference is enough, at least for now. You could add the reference to the derivatives:
Raphael Hartmann and Karl Christoph Klauer. 2021. Partial derivatives for the first-passage time distribution in Wiener diffusion models. Journal of Mathematical Psychology.
@article{hartmann2021partial,
title={Partial derivatives for the first-passage time distribution in {W}iener diffusion models},
author={Hartmann, Raphael and Klauer, Karl Christoph},
journal={Journal of Mathematical Psychology},
volume={103},
pages={102550},
year={2021},
publisher={Elsevier}
}There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Franzi2114 is there a preprint available?
No, there is no preprint available. I hope that it will be published soon. All proofs are already done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove it for now. Let us know when it is available and we will add the citation then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Franzi2114 and good luck getting the paper out---I know how frustrating this is. Do they not let you put up arXiv versions in the interim? We could cite that.
Submission Checklist
<<{ since VERSION }>>Summary
Documentation for stan-dev/stanc3#1576 / stan-dev/math#3042.
The tex and prose was provided by @Franzi2114, I've just done the formatting and signature documentation.
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
Franziska Henrich
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: