Flag to indicate whether to return deprecated models #1641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...a/io/stargate/sgv2/jsonapi/service/operation/embeddings/FindEmbeddingProvidersOperation.java
Outdated
Show resolved
Hide resolved
tatu-at-datastax
approved these changes
Nov 5, 2024
Contributor
tatu-at-datastax
left a comment
tatu-at-datastax
left a comment
There was a problem hiding this comment.
Looks good: one requested change, one suggested
.../stargate/sgv2/jsonapi/service/operation/embeddings/FindEmbeddingProvidersOperationTest.java
Outdated
Show resolved
Hide resolved
| * @return Flag to indicate whether to return deprecated models in the | ||
| * FindEmbeddingProvidersCommand's response. | ||
| */ | ||
| @WithDefault("false") |
Contributor
There was a problem hiding this comment.
should we default true?
Contributor
|
What is the flag added to ? and how is it set and why do we need this ? |
amorton
requested changes
Nov 11, 2024
Contributor
amorton
left a comment
amorton
left a comment
There was a problem hiding this comment.
Hold on this - it is not clear what the problem is we are trying to solve, and why this is the correct solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Added flag to indicate whether to return deprecated models in the response
Checklist