-
Notifications
You must be signed in to change notification settings - Fork 24
Usage metering for embedding and reranking #2008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Picking this work up, and combining it with #1865 |
tests not verified
get the request config from ServiceConfigStore
Yuqi-Du
commented
Jun 17, 2025
src/main/java/io/stargate/sgv2/jsonapi/service/embedding/operation/EmbeddingProvider.java
Outdated
Show resolved
Hide resolved
Yuqi-Du
commented
Jun 17, 2025
Yuqi-Du
commented
Jun 17, 2025
Yuqi-Du
commented
Jun 17, 2025
Yuqi-Du
commented
Jun 17, 2025
src/main/java/io/stargate/sgv2/jsonapi/service/embedding/gateway/EmbeddingGatewayClient.java
Show resolved
Hide resolved
Yuqi-Du
commented
Jun 17, 2025
...n/java/io/stargate/sgv2/jsonapi/service/embedding/operation/AwsBedrockEmbeddingProvider.java
Show resolved
Hide resolved
Yuqi-Du
commented
Jun 17, 2025
src/main/java/io/stargate/sgv2/jsonapi/service/provider/ModelInputType.java
Outdated
Show resolved
Hide resolved
amorton
approved these changes
Jun 18, 2025
Contributor
amorton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed by yuqi
Hazel-Datastax
added a commit
that referenced
this pull request
Jun 23, 2025
This reverts commit 48857a2.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add ModelUsage as part the BatchedRerankingResponse.
The idea is to generalize ModelUsage that will be common shared by reranking and embedding model service.
Note that, gRPC prototype also changed to reflect the shared modelUsage structure.
So This PR will has corresponding EGW changes.
Checklist