Batch 11 of #2285: convert ErroCodeV1s to RequestExceptions
#2320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📈 Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
Contributor
📉 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
Contributor
📉 Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
| Resend command with valid value. | ||
| - scope: | ||
| code: COMMAND_FIELD_UNKNOWN |
Contributor
There was a problem hiding this comment.
what's the difference between "COMMAND_FIELD_INVALID" and "COMMAND_FIELD_UNKNOWN"? Can we combine them?
Contributor
Author
There was a problem hiding this comment.
Let me check, good question.
Contributor
Author
There was a problem hiding this comment.
Ah. So, COMMAND_FIELD_INVALID really needs to be COMMAND_FIELD_VALUE_INVALID -- so it's value of a (known) field that is somehow wrong vs COMMAND_FIELD_UNKNOWN where field name itself is unrecognized.
I will rename the code to better reflect this.
Good catch!
Hazel-Datastax
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Converts Request-specific
ErrorCodeV1s toRequestException.CodesWhich issue(s) this PR fixes:
Part of #2285
Checklist