Skip to content

Conversation

@jasonvarga
Copy link
Member

@jasonvarga jasonvarga commented Jan 5, 2026

When attempting to compile an addon's js, it would fail on certain keys like module.exports.

error during build:
vue-external (4:1284): Expected ',', got '.' (Note that you need plugins to import files that are not JavaScript)
file: vue-external:4:1284

Object.keys(Vue) contained module.exports for the user who reported this issue. They are using Node 24. I'm using Node 22 and it doesn't contain module.exports. I don't have Node 24 to confirm that is exactly the issue, but this regex addition will filter out invalid keys regardless.

@jasonvarga jasonvarga merged commit d710188 into master Jan 5, 2026
13 checks passed
@jasonvarga jasonvarga deleted the vite-exports branch January 5, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants