GetTablesInSchema to ignorw materialized views, system, temporary and non-data tables #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prybintsev
force-pushed
the
ignore-materialized-views-and-system-tables
branch
from
cd852dd to
d93a0cf
Compare
…ystem-tables GetTablesInSchema to ignorw materialized views, system, temporary and…
prybintsev
force-pushed
the
ignore-materialized-views-and-system-tables
branch
from
d93a0cf to
02e105b
Compare
Contributor
|
I've also added an integration tests not to test that to ensure no regression here anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is impossible to run silk sql against clickhouse schemas that have materialized views, due to the following error:
unable to setup postgres sinker: load psql table: invalid table: sql sink requires a primary key in every table, none was found in table substreams_evm_tokens.mv_erc20_metadata_changesclickhouse views don't have primary keys.
In previous versions streamingfast/schema was used to retrieve the list of clickhouse tables, that filtered materialized views and some other types of tables
https://github.com/streamingfast/schema/blob/master/dialect_clickhouse.go#L11
This PR ports the filtering logic from streamingfast/schema