Skip to content

Conversation

@bigfooted
Copy link
Contributor

@bigfooted bigfooted commented Dec 22, 2025

Proposed Changes

  • use reference temperature for enthalpy consistenly
  • Write temperature to paraview when energy=off, being consistent with other thermodynamic quantities like viscosity.
  • Fixed a bug when restarting with species.
  • When energy=off, enthalpy field will still be used to compute temperature (necessary for python wrapper)
  • Fixed an MPI bug where viscosity was out of sync when computing non-constant mass diffusivity
  • update python wrapper case. No need to put ENERGY=ON anymore. temperature field is written to paraview

Related Work

small fixes for #2426

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@bigfooted bigfooted changed the title fixe scalar restart, update psi case fix scalar restart, update psi case Dec 22, 2025
@bigfooted bigfooted changed the title fix scalar restart, update psi case Fix scalar restart, update psi case Dec 22, 2025
@bigfooted bigfooted changed the title Fix scalar restart, update psi case [WIP] Fix scalar restart, update psi case Dec 22, 2025
bigfooted and others added 4 commits December 22, 2025 11:22
Co-authored-by: Cristopher Morales <98025159+Cristopher-Morales@users.noreply.github.com>
@bigfooted bigfooted changed the title [WIP] Fix scalar restart, update psi case Fix scalar restart, update psi case Dec 22, 2025
@bigfooted bigfooted changed the title Fix scalar restart, update psi case [WIP] Fix scalar restart, update psi case Dec 22, 2025
@bigfooted bigfooted marked this pull request as draft December 22, 2025 14:23
@bigfooted bigfooted changed the title [WIP] Fix scalar restart, update psi case [WIP] Fix enthalpy related issues Dec 23, 2025
@pcarruscag
Copy link
Member

Is this the only known issue after the enthalpy change? Are we in a good place to make a release?

@bigfooted
Copy link
Contributor Author

Is this the only known issue after the enthalpy change? Are we in a good place to make a release?

I have checked some testcases in more detail, specifically the combustion testcases and they all look fine.

@bigfooted bigfooted merged commit 23383dd into develop Jan 6, 2026
19 of 20 checks passed
@bigfooted bigfooted deleted the fix_restart_scalars branch January 6, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants