-
Notifications
You must be signed in to change notification settings - Fork 913
Fix enthalpy related issues #2652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+265
−240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Cristopher Morales <98025159+Cristopher-Morales@users.noreply.github.com>
…into fix_restart_scalars
bigfooted
commented
Dec 22, 2025
bigfooted
commented
Dec 22, 2025
…into fix_restart_scalars
5 tasks
…into fix_restart_scalars
bigfooted
commented
Jan 5, 2026
bigfooted
commented
Jan 5, 2026
bigfooted
commented
Jan 5, 2026
TestCases/flamelet/04_laminar_premixed_ch4_flame_cht_ad/lam_prem_ch4_cht_ad_fluid.cfg
Outdated
Show resolved
Hide resolved
bigfooted
commented
Jan 5, 2026
TestCases/flamelet/04_laminar_premixed_ch4_flame_cht_ad/lam_prem_ch4_cht_ad_solid.cfg
Outdated
Show resolved
Hide resolved
bigfooted
commented
Jan 5, 2026
TestCases/flamelet/04_laminar_premixed_ch4_flame_cht_ad/lam_prem_ch4_cht_ad_fluid.cfg
Outdated
Show resolved
Hide resolved
…em_ch4_cht_ad_fluid.cfg
…em_ch4_cht_ad_solid.cfg
…em_ch4_cht_ad_fluid.cfg
Member
|
Is this the only known issue after the enthalpy change? Are we in a good place to make a release? |
Contributor
Author
I have checked some testcases in more detail, specifically the combustion testcases and they all look fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Related Work
small fixes for #2426
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.