Skip to content

Conversation

@shbhmexe
Copy link

@shbhmexe shbhmexe commented Dec 24, 2025

Proposed Changes

This PR fixes four bugs - two in Python and two in C++:

# File Issue Fix
1 SU2_PY/SU2/io/tools.py expand_time() loses multi-zone filenames Use extend() instead of reassignment
2 SU2_PY/SU2/eval/gradients.py Wrong key check (RESTART_FILE_1 vs _2) Check correct key before access
3 SU2_CFD/.../flow_diffusion.cpp Division by zero in AddTauWall fmax(WallShearStress, EPS)
4 SU2_CFD/.../CRadP1Solver.cpp Division by zero in SetTime_Step fmax(Absorption + Scattering, EPS)

Related Work

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings.
  • My contribution is commented and consistent with SU2 style.
  • I used the pre-commit hook to prevent dirty commits.
  • I have updated appropriate documentation, if necessary.

1. tools.py: expand_time() - use extend() for multi-zone lists
2. gradients.py: fix RESTART_FILE_2 key check
3. flow_diffusion.cpp: protect WallShearStress division
4. CRadP1Solver.cpp: protect GammaP1 coefficient division

Signed-off-by: Shubham <shubhushukla586@gmail.com>
@pcarruscag pcarruscag merged commit 8ddd591 into su2code:develop Dec 24, 2025
37 of 38 checks passed
@shbhmexe shbhmexe deleted the fix/io-tools-expand-time-list-handling branch December 25, 2025 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants