fix: max sendable lightning calc doesn't account for routing fee #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvsena42
commented
Dec 23, 2025
ovitrif
reviewed
Dec 23, 2025
Collaborator
ovitrif
left a comment
ovitrif
left a comment
There was a problem hiding this comment.
utAck, one remark then it LGTM's
Member
Author
|
@piotr-iohk this test probably need an update too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #533
Description
This PR adds a round fee accounting to the max sendable lightning amount, with a 2 sats buffer. Also changes the 50% total balance sanity check to use individual unchain/lightning balance instead of total balance
Preview
lightning.webm
onchain.webm
QA Notes