Skip to content

fix: fallback to on-chain when BIP21 has expired LN invoice #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jvsena42 merged 3 commits into from
Jan 5, 2026
Merged

fix: fallback to on-chain when BIP21 has expired LN invoice #567

jvsena42 merged 3 commits into from
Jan 5, 2026

Conversation

@jvsena42
Copy link
Member

@jvsena42 jvsena42 commented Jan 3, 2026 •
edited
Loading

Closes #366

Description

This PR fallback to on-chain invoice when a BIP21 has an expired lightning invoice

Preview

no-amount.webm
with-amount.webm
ln-only.webm

QA Notes

Make a invoice fail faster :

    suspend fun createInvoice(
        amountSats: ULong? = null,
        description: String,
        expirySeconds: UInt = 10u,
  • Unified invoice without amount
  • Unified invoice with amount
  • Expired lightning invoice

@jvsena42 jvsena42 self-assigned this Jan 3, 2026
@jvsena42 jvsena42 changed the title Fix/fallback expired ln to onchain fix: fallback expired ln on unified invoice to onchain Jan 3, 2026
@jvsena42 jvsena42 marked this pull request as ready for review January 5, 2026 10:34
@jvsena42 jvsena42 enabled auto-merge January 5, 2026 10:35
@jvsena42 jvsena42 changed the title fix: fallback expired ln on unified invoice to onchain fix: fallback to on-chain when BIP21 has expired LN invoice Jan 5, 2026
@jvsena42 jvsena42 requested a review from ovitrif January 5, 2026 10:36
@jvsena42
Copy link
Member Author

jvsena42 commented Jan 5, 2026

@piotr-iohk this probably also unblock some E2E test

@piotr-iohk piotr-iohk mentioned this pull request Jan 5, 2026
Merged
@piotr-iohk
Copy link
Collaborator

piotr-iohk commented Jan 5, 2026

@piotr-iohk this probably also unblock some E2E test

Yes. Tests updated: synonymdev/bitkit-e2e-tests#93

Unfortunately it is also observed in iOS (created an issue: synonymdev/bitkit-ios#300), missed to check this earlier 😅

ovitrif
ovitrif approved these changes Jan 5, 2026
View reviewed changes
Copy link
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck, looks clean and simple!

@jvsena42 jvsena42 merged commit fa7e9f4 into master Jan 5, 2026
28 of 31 checks passed
@jvsena42 jvsena42 deleted the fix/fallback-expired-ln-to-onchain branch January 5, 2026 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ovitrif ovitrif ovitrif approved these changes

Assignees

@jvsena42 jvsena42

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expired Lightning in unified invoice fails instead of falling back to Bitcoin address

4 participants

@jvsena42 @piotr-iohk @ovitrif