Skip to content

Conversation

@Tunglies
Copy link
Contributor

@Tunglies Tunglies commented Dec 5, 2025

Related: #1332, tauri-apps/tauri#14443 tauri-apps/tauri#14360
Not totally resolved for these.

Simplfy impl Drop for CommandChild, only takes effect on tauri-plugin-shell, whether if it is sidecar or normal command. Taks advantage of rust's liftime control. Before the impl, drop has no any operation. Has no any additional external tool usage or invoke helper program. Competiable with tauri dev.

Usage:

let command = app_handle
    .clone()
    .shell()
    .sidecar(EXTERNAL_BIN)?;
command.set_kill_on_drop(true);

@Tunglies Tunglies requested a review from a team as a code owner December 5, 2025 15:37
@Tunglies
Copy link
Contributor Author

Tunglies commented Dec 5, 2025

CC @Legend-Master and @FabianLars

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Package Changes Through 0851d5b

There are 21 changes which include dialog-js with minor, dialog with minor, log with minor, log-js with minor, localhost with patch, shell with minor, shell-js with minor, barcode-scanner with patch, barcode-scanner-js with patch, deep-link with patch, deep-link-js with patch, http with patch, http-js with patch, nfc with patch, nfc-js with patch, updater with minor, updater-js with minor, upload with minor, upload-js with minor, websocket with patch, websocket-js with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.38 2.0.39
api-example-js 2.0.34 2.0.35
deep-link-example-js 2.2.8 2.2.9
barcode-scanner 2.4.2 2.4.3
barcode-scanner-js 2.4.2 2.4.3
deep-link 2.4.5 2.4.6
deep-link-js 2.4.5 2.4.6
dialog 2.4.2 2.5.0
dialog-js 2.4.2 2.5.0
http 2.5.4 2.5.5
http-js 2.5.4 2.5.5
localhost 2.3.1 2.3.2
log 2.7.1 2.8.0
log-js 2.7.1 2.8.0
nfc 2.3.3 2.3.4
nfc-js 2.3.3 2.3.4
shell 2.3.3 2.4.0
shell-js 2.3.3 2.4.0
single-instance 2.3.6 2.3.7
updater 2.9.0 2.10.0
updater-js 2.9.0 2.10.0
upload 2.3.2 2.4.0
upload-js 2.3.2 2.4.0
websocket 2.4.1 2.4.2
websocket-js 2.4.1 2.4.2

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@Legend-Master
Copy link
Contributor

I don't mind adding this but it doesn't really sound like something related to the issues/PRs you linked?

@Tunglies
Copy link
Contributor Author

Tunglies commented Dec 7, 2025

If more complex logic is introduced in the future, using drop(command) will make it easier to extend the data structures. No more external system tool need invoked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants