Skip to content

Conversation

@mrquantumoff
Copy link

@mrquantumoff mrquantumoff commented Jan 4, 2026

Flathub no longer allows the "org.app_id.SingleInstance" dbus id that was allowed as an exception previously. Thus, I implemented an optional feature that would allow developers to use a more conventional dbus name that would pass the Flathub inspections without causing extra issues.

The Flathub discussion
flathub-infra/flatpak-builder-lint#819 (comment)

@mrquantumoff mrquantumoff requested a review from a team as a code owner January 4, 2026 09:53
@FabianLars
Copy link
Member

I really appreciate the PR but please check out #3184, we've had a slightly different approach in mind.

@mrquantumoff
Copy link
Author

Thank you for informing me about your approach to this issue. I suppose your way of solving the problem is better than just adding an another feature to the crate. In this case, I'll wait for the official implementation and use my own implementation for the time being.

@FabianLars
Copy link
Member

nono your implementation wasn't that far off. I just wouldn't put it behind a feature flag and instead force the new ids on all users 🤷

@FabianLars
Copy link
Member

one thing that's a bit of an annoyance with zbus is the interface name, i'd like to have that match the dbus name but it needs to be defined at build time if we don't want to code everything ourselves. The spec says "should ..." when it comes to that though so ig it doesn't matter that much

@mrquantumoff mrquantumoff reopened this Jan 4, 2026
@mrquantumoff mrquantumoff marked this pull request as draft January 4, 2026 15:43
@mrquantumoff
Copy link
Author

In that case, I'll rework some part of it, to match the intended vision a bit more

@mrquantumoff mrquantumoff changed the title Add a "conventional dbus" feature in order to be able to publish to flathub easily Fix the unconventional dbus names in the single instancew plugin Jan 4, 2026
@mrquantumoff
Copy link
Author

I added an option to set the DBus ID at compile time. Made the conventional dbus naming the standard one. I chose to check for DBUS_ID instead of FLATPAK_ID in order to keep better compatability with people who want to package snaps.

@mrquantumoff mrquantumoff marked this pull request as ready for review January 4, 2026 17:01
@mrquantumoff mrquantumoff changed the title Fix the unconventional dbus names in the single instancew plugin Fix the unconventional dbus names in the single instance plugin Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants