-
Notifications
You must be signed in to change notification settings - Fork 51
chore: update dependencies #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update dependencies #403
Conversation
Signed-off-by: Rene Leonhardt <65483435+reneleonhardt@users.noreply.github.com>
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Notes
https://github.com/tensorchord/VectorChord/actions/runs/20807681917/job/59765092508#step:2:7
|
usamoi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please restrict the scope of this PR to updating the versions of cargo-deny and sqllogictest, and configuring Dependabot for GitHub Actions.
.github/workflows/release.yml
Outdated
| version: ["14", "15", "16", "17", "18"] | ||
| arch: ["x86_64", "aarch64"] | ||
| runs-on: ${{ matrix.arch == 'x86_64' && 'ubuntu-22.04' || 'ubuntu-22.04-arm' }} | ||
| runs-on: ${{ matrix.arch == 'x86_64' && 'ubuntu-24.04' || 'ubuntu-24.04-arm' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This raises the minimum required libc version for the binary package, which is unacceptable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about check:psql?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not very important, but it would be better if both use the same version. This way, we won't run into unexpected issues during the release.
…owed to test security updates for regressions Signed-off-by: Rene Leonhardt <65483435+reneleonhardt@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates dependencies and drops PostgreSQL 13 support following its EOL date. The changes include updating Cargo dependencies (rusqlite, object, and their transitive dependencies), pinning GitHub Actions with commit hashes for improved supply chain security, removing PostgreSQL 13 from CI matrix configurations, and configuring Dependabot to manage future updates.
Key changes:
- Removed PostgreSQL 13 feature flags and conditional compilation directives from modified source files
- Updated minimum PostgreSQL runtime requirement from 13.0.0 to 14.0.0
- Added Dependabot configuration with cooldown periods for GitHub Actions updates
- Pinned all GitHub Actions to specific commit hashes instead of version tags
- Updated PostgreSQL binaries in CI workflows to latest patch versions
- Updated development tool versions (sqllogictest, cargo-deny, Intel SDE)
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/vchordrq/pushdown_plan.slt | Removed PostgreSQL 13-specific test cases |
| src/lib.rs | Removed pg13 from feature flag conditional for EmitWarningsOnPlaceholders |
| src/index/storage/buffered.rs | Removed pg13 from extend method feature flag |
| src/index/storage.rs | Removed pg13 from multiple conditional compilation directives |
| src/index/scanners.rs | Removed pg13 from dead_code expectation attribute |
| src/index/gucs.rs | Removed pg13 from GUC default value conditionals and placeholder warnings |
| crates/xtask/src/main.rs | Removed pg13 from macOS extension suffix matching |
| crates/xtask/Cargo.toml | Updated object dependency from 0.37.3 to 0.38.1 |
| META.json.in | Updated minimum PostgreSQL requirement from 13.0.0 to 14.0.0 |
| Cargo.toml | Removed pg13 feature definition and updated rusqlite from 0.37.0 to 0.38.0 |
| Cargo.lock | Updated dependency versions including hashbrown, hashlink, libsqlite3-sys, object, rusqlite, and wasmparser |
| .github/workflows/release.yml | Removed pg13 from version matrix and pinned GitHub Actions to commit hashes |
| .github/workflows/cla.yml | Pinned contributor-assistant/github-action to commit hash |
| .github/workflows/check.yml | Removed pg13 from all test matrices, updated PostgreSQL binaries, pinned actions, and updated development tools |
| .github/dependabot.yml | Added new configuration for Cargo and GitHub Actions dependency updates with cooldown periods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
usamoi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the compilation warnings.
https://github.com/tensorchord/VectorChord/actions/runs/20855548368/job/59923453739?pr=403
Signed-off-by: Rene Leonhardt <65483435+reneleonhardt@users.noreply.github.com>
|
Make sure to squash all commits when merging. |
Signed-off-by: Rene Leonhardt <65483435+reneleonhardt@users.noreply.github.com>
Signed-off-by: Rene Leonhardt <65483435+reneleonhardt@users.noreply.github.com>
|
Thank you! |
|
You're welcome! If you're open to it, I could automate more CI dependencies like deny and sqllogic with Renovatebot. |
Chores