Do not transfer mountable file when tar name is "." or ".." #2258
+154
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedla
force-pushed
the
check-transferable-names
branch
from
cac196e to
1ce9a4c
Compare
bsideup
reviewed
Apr 11, 2020
core/src/test/java/org/testcontainers/utility/DirectoryTarResourceTest.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Apr 11, 2020
core/src/test/java/org/testcontainers/utility/DirectoryTarResourceTest.java
Outdated
Show resolved
Hide resolved
bedla
force-pushed
the
check-transferable-names
branch
2 times, most recently
from
33017e7 to
cfb6086
Compare
…s unable to use this files)
bedla
force-pushed
the
check-transferable-names
branch
from
2aeecf1 to
6727a9a
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
|
This issue has been automatically closed due to inactivity. We apologise if this is still an active problem for you, and would ask you to re-open the issue if this is the case. |
Contributor
Author
|
I have rebased PR to current master. |
Contributor
Author
|
new PR here #3895 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I found that when I use
.or..as mountable-file with host path to regular path docker is unable to use this files during build (they actually are transferred to docker in TAR payload).As you can see I have created PR to check if host path is file and name is "invalid" to throw exception. I found this glitch when I was assuming that
withFileFromFile(".", new File("path/to/file.txt"))will safe file to "current" working directory.with namefile.txtor in path./path/to/file.txt.Please check PR if it makes sense.
Thx
Ivos