ASoC: SOF: ipc-topology: Add float and 8-bit formats #5401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singalsu
force-pushed
the
add_8bit_support
branch
from
09391c7 to
e1bfb75
Compare
singalsu
commented
Apr 30, 2025
singalsu
force-pushed
the
add_8bit_support
branch
from
e1bfb75 to
a5a5371
Compare
ranj063
reviewed
May 1, 2025
Author
|
SOFCI TEST |
singalsu
force-pushed
the
add_8bit_support
branch
2 times, most recently
from
18cc681 to
a742f2c
Compare
Author
|
I combined all the patches, not sure if this can be split to preparation and feature enable. I've tested this with script like below UPX i11 device with this kernel patch and firmware thesofproject/sof#9980. Then copied from DUT the nocodec loopback wav files and checked visually them with spectrogram in audio editor. The chirp should sound and look clean with all formats combinations. |
singalsu
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
plbossart and
ujfalusi
as code owners
singalsu
force-pushed
the
add_8bit_support
branch
from
a742f2c to
9e2921c
Compare
Author
|
No changes, just rebased and improved commit text to re-launch SOFCI. |
ujfalusi
requested changes
May 22, 2025
sound/soc/sof/ipc4-topology.c
Outdated
Collaborator
There was a problem hiding this comment.
if (params_physical_width(fe_params) <= 16)
pipeline->msg.primary |= SOF_IPC4_GLB_CHAIN_DMA_SCS_MASK;
singalsu
force-pushed
the
add_8bit_support
branch
from
9e2921c to
1ae4f3f
Compare
This patch enables use of 8-bit unsigned, A-law, and mu-law sample formats with IPC4 SOF. The ipc4-topology.h is updated with IPC4 sample types. The purpose is to to convert ALSA types to IPC4 types. The functions of_ipc4_update_hw_params(), sof_ipc4_get_valid_bits(), and new function sof_ipc4_get_sample_type() are updated to handle the sample type conversions. The function sof_ipc4_prepare_copier_module() is updated to set the DMA SCS bit for all non 32 bits sample types. The change to function sof_ipc4_get_valid_bits() returns 8 bits for these ALSA formats. The change to function sof_ipc4_prepare_copier_module() is needed to handle properly all non 32-bit formats with SCS bit set. To support playback with new 8 bits types, the sof_ipc4_init_input_audio_fmt() function is updated to get the sample type and use it in search for copier input pin format. To support capture, the sof_ipc4_init_output_audio_fmt() is updated similarly. Since the function uses separate out_ref_type argument, instead of single parameters struct, the out_ref_type needs to be added to every user of the function. Therefore functions sof_ipc4_prepare_copier_module(), sof_ipc4_prepare_gain_module(), sof_ipc4_prepare_mixer_module(), sof_ipc4_prepare_src_module(), and sof_ipc4_prepare_process_module() are updated to set the out_ref_type. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch adds support for FLOAT_LE ALSA type for playback and capture for IPC4 systems. Functions sof_ipc4_update_hw_params(), sof_ipc4_get_valid_bits() and sof_ipc4_get_sample_type() are updated to handle SOF_IPC4_TYPE_FLOAT and SNDRV_PCM_FORMAT_FLOAT_LE. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
add_8bit_support
branch
from
1ae4f3f to
9b13ced
Compare
singalsu
changed the title
Author
bardliao
approved these changes
Jun 18, 2025
jsarha
approved these changes
Jun 18, 2025
lgirdwood
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for the changes.