Skip to content

Test-case: Add amixer card selection by name #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
golowanow merged 1 commit into from
Mar 17, 2025
Merged

Test-case: Add amixer card selection by name #1264

golowanow merged 1 commit into from
Mar 17, 2025

Conversation

@harajend
Copy link
Contributor

@harajend harajend commented Mar 14, 2025

No description provided.

@harajend harajend requested review from a team, golowanow, lgirdwood and marc-hb as code owners March 14, 2025 19:20
@harajend harajend mentioned this pull request Mar 14, 2025
Closed
@sofci
Copy link
Collaborator

sofci commented Mar 14, 2025

Can one of the admins verify this patch?

reply test this please to run this test once

@harajend harajend mentioned this pull request Mar 14, 2025
Closed
@harajend harajend force-pushed the fix/alsabat branch 2 times, most recently from 686fd1b to ef4feb8 Compare March 14, 2025 19:42
marc-hb
marc-hb reviewed Mar 14, 2025
View reviewed changes
@harajend harajend requested a review from marc-hb March 14, 2025 19:55
golowanow
golowanow reviewed Mar 14, 2025
View reviewed changes
Copy link
Member

@golowanow golowanow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harajend, could you please fill the commit description (now empty) with short info on what problem/issue it resolves, and add a reference to the issue at the end, e.g. Fixes: #1265

golowanow
golowanow reviewed Mar 17, 2025
View reviewed changes
@golowanow
Copy link
Member

golowanow commented Mar 17, 2025 •
edited
Loading

please squeeze into single commit, and wrap commit message lines <72 chars.

@harajend harajend force-pushed the fix/alsabat branch 2 times, most recently from 2056f51 to 4891b83 Compare March 17, 2025 09:19
@harajend
test-case/check-alsabat.sh: Select the first card for amixer contents
58a7077 
Amixer, by default, looks for the first card, and in Amixer's view,
the first card is always numbered 0.

In the SoundWire configuration, card 0 is set to sof-probe, while
card 1 is assigned to the actual sound card. Therefore, we are
configuring it accordingly.

Fixes: thesofproject#1265

Signed-off-by: Hariprasad, Rajendra <hariprasad.rajendra@intel.com>
@golowanow golowanow merged commit 114f37b into thesofproject:main Mar 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kv2019i kv2019i kv2019i approved these changes

@golowanow golowanow golowanow approved these changes

@lgirdwood lgirdwood Awaiting requested review from lgirdwood lgirdwood is a code owner

@marc-hb marc-hb Awaiting requested review from marc-hb marc-hb is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@harajend @sofci @golowanow @kv2019i @marc-hb