Skip to content

Conversation

@majunkier
Copy link
Contributor

Create WCL platform ALSA settings state files for:

  • WCL_HDA_AIOC
  • WCL_SDW_RT712
  • WCL_RVP_SDW

The parameters in the state files are explicitly set even if the default values at the appropriate DUT are currently the same.

Create WCL platform ALSA settings state files for:

 * WCL_HDA_AIOC
 * WCL_SDW_RT712
 * WCL_RVP_SDW

The parameters in the state files are explicitly set even if
the default values at the appropriate DUT are currently the same.

Signed-off-by: Mateusz Junkier <mateusz.junkier@intel.com>
Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As usual I wonder why these are not already the default.

The parameters in the state files are explicitly set even if
the default values at the appropriate DUT are currently the same.

Does that mean tests should pass even when all other users have bad settings?

@majunkier
Copy link
Contributor Author

As usual I wonder why these are not already the default.

The parameters in the state files are explicitly set even if
the default values at the appropriate DUT are currently the same.

Does that mean tests should pass even when all other users have bad settings?

i believe most discussion was in PR1294 and PR1270 . In summary, some tests may modify ALSA settings without restoring defaults, which can lead to failures

@KamilxPaszkiet KamilxPaszkiet merged commit 7e4bfd8 into thesofproject:main Sep 3, 2025
5 of 8 checks passed
@marc-hb
Copy link
Collaborator

marc-hb commented Sep 3, 2025

In summary, some tests may modify ALSA settings without restoring defaults, which can lead to failures

There are (at least) two different questions:

  1. Who cleans up and when.
  2. What cleanup is performed and how

The general answer to 1. is easy and well-known: in general each test should CLEAN-TEST-CLEAN. The first clean is for itself, the second clean is for other users: either interactive users or to help "bad" tests (which should be fixed eventually).

EDIT: there are optimization trade-offs; you cannot reboot before every test.

I don't think 1. is relevant to this PR. This PR is about 2.

i believe most discussion was in #1294

Yes, and based on the discussion there, why is alsactl restore not enough? Every time sof-test hides some "private" ALSA settings like this, it means people and machines who do not use sof-test will miss them. Sometimes it's necessary but it should ideally be temporary and always justified and documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants