Skip to content

check-kmod-load-unload: use TOPDIR, don't rely on PATH #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marc-hb merged 3 commits into from
Dec 2, 2021
Merged

check-kmod-load-unload: use TOPDIR, don't rely on PATH #808

marc-hb merged 3 commits into from
Dec 2, 2021

Conversation

@marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Nov 22, 2021

This was apparently the only test in run-all-tests.sh that required a PATH change.

@marc-hb marc-hb marked this pull request as ready for review November 22, 2021 20:22
@marc-hb marc-hb requested a review from a team as a code owner November 22, 2021 20:22
@marc-hb
Copy link
Collaborator Author

marc-hb commented Nov 22, 2021

https://sof-ci.01.org/softestpr/PR808/build924/devicetest/?model=APL_UP2_NOCODEC&testcase=check-suspend-resume-with-capture-5 is 5.6-rc1 regression thesofproject/linux#3283

The alsabat failure is also unrelated, this PR changes only one, different test.

@marc-hb
check-kmod-load-unload: add new TOPDIR constant
2510895 
TOPDIR can be re-used to find other test files.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb
check-kmod-load-unload: use TOPDIR, don't rely on PATH
09442f4 
This was apparently the only test in run-all-tests.sh that required a
PATH change.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb
kmod/sof_insert: add comment explaining how pam_unix slows sudo
3037e38 
This is the place where this "sudo performance" issue is the most
visible

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb marc-hb requested a review from plbossart as a code owner November 23, 2021 22:27
@marc-hb
Copy link
Collaborator Author

marc-hb commented Nov 24, 2021 •
edited
Loading

Big regressions in https://sof-ci.01.org/softestpr/PR808/build927/devicetest/ unrelated to this, see thesofproject/linux#3292 for more details.

EDIT: fixed by revert thesofproject/linux#3294

@marc-hb
Copy link
Collaborator Author

marc-hb commented Nov 24, 2021

SOFCI TEST

@greg-intel
Copy link
Contributor

greg-intel commented Nov 24, 2021

I'm not sure of the specific intent, but all the changes more or less make sense to me. I don't see any obvious issues, assuming the following isn't related:
2021-11-24 04:16:00 UTC Sub-Test: [REMOTE_ERROR] Caught error in kernel log 2021-11-24 04:16:00 UTC Sub-Test: [REMOTE_ERROR] Starting func_exit_handler(), exit status=1, FUNCNAME stack: 2021-11-24 04:16:00 UTC Sub-Test: [REMOTE_ERROR] die() @ /home/ubuntu/sof-test/test-case/../case-lib/lib.sh 2021-11-24 04:16:00 UTC Sub-Test: [REMOTE_ERROR] main() @ /home/ubuntu/sof-test/test-case/check-suspend-resume.sh:91 2021-11-24 04:16:00 UTC Sub-Test: [REMOTE_ERROR] main() @ /home/ubuntu/sof-test/test-case/check-suspend-resume.sh:91 2021-11-24 04:16:00 UTC Sub-Test: [REMOTE_INFO] Test Result: FAIL!

@marc-hb
Copy link
Collaborator Author

marc-hb commented Nov 24, 2021

https://sof-ci.01.org/softestpr/PR808/build929/devicetest/?model=CML_RVP_SDW&testcase=check-suspend-resume-with-playback-5 is "preemptible" BUG thesofproject/linux#3283

sh-cml-sku0955-hda-02 crashed in the middle of the test run before running this test, so unrelated.

Everything else is green.

@greg-intel
Copy link
Contributor

greg-intel commented Dec 2, 2021 •
edited
Loading

Last question, @marc-hb, Did the GitHub actions test these script changes?
[Update] I see now that the script is checked by sof-ci, and the other change is comments.

greg-intel
greg-intel approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@greg-intel greg-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fairly straightforward.

@marc-hb marc-hb requested a review from a team December 2, 2021 21:50
@marc-hb
Copy link
Collaborator Author

marc-hb commented Dec 2, 2021

Minor, zero functional change up for 10 days in review : merging.

@marc-hb marc-hb merged commit 46daf46 into thesofproject:main Dec 2, 2021
@marc-hb marc-hb deleted the kmod-topdir branch December 2, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@plbossart plbossart Awaiting requested review from plbossart plbossart is a code owner

1 more reviewer

@greg-intel greg-intel greg-intel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marc-hb @greg-intel