lib.sh: switch is_zephyr() to look for zephyr strings in .ldc #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the sof-logger is well tested with Zephyr, change the is_zephyr() test to count the number of "zephyr" strings in the .ldc dictionary file. The previous test was based on /etc/sof/manifest.txt which is a CI-only file. This probably removes a dependency on 'jq' too. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Collaborator
Author
|
Big regressions in https://sof-ci.01.org/softestpr/PR810/build926/devicetest unrelated to this, see thesofproject/linux#3292 for more details. EDIT: fixed by revert thesofproject/linux#3294 |
Collaborator
Author
|
SOFCI TEST https://sof-ci.01.org/softestpr/PR810/build928/devicetest looks much better. "premptible" suspend/resume issue thesofproject/linux#3283 + some known race condition at ADL boot |
keqiaozhang
approved these changes
Nov 24, 2021
Contributor
keqiaozhang
left a comment
keqiaozhang
left a comment
There was a problem hiding this comment.
This removes the dependency on jq.
marc-hb
requested review from
dbaluta,
dcpleung,
greg-intel,
kv2019i and
lyakh
greg-intel
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the sof-logger is well tested with Zephyr, change the
is_zephyr() test to count the number of "zephyr" strings in the .ldc
dictionary file. The previous test was based on /etc/sof/manifest.txt
which is a CI-only file. This probably removes a dependency on 'jq' too.
Signed-off-by: Marc Herbert marc.herbert@intel.com