Skip to content

Add support for hostless/dailess pipelines #10329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kv2019i merged 3 commits into from
Dec 18, 2025
Merged

Add support for hostless/dailess pipelines #10329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a24b406
audio: tone: Add IPC4 tone implementation
ranj063 Dec 12, 2025
6ea0e7a
topology2: components: siggen: Add new module
ranj063 Nov 20, 2025
ce5d2b5
topology2: components: pipeline: Add direction attribute
ranj063 Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/arch/host/configs/library_defconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ CONFIG_COMP_SRC=y
CONFIG_COMP_SRC_IPC4_FULL_MATRIX=y
CONFIG_COMP_STUBS=y
CONFIG_COMP_TDFB=y
CONFIG_COMP_TONE=y
CONFIG_COMP_VOLUME=y
CONFIG_COMP_VOLUME_LINEAR_RAMP=y
CONFIG_COMP_VOLUME_WINDOWS_FADE=y
Expand Down
4 changes: 1 addition & 3 deletions src/audio/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,7 @@ if(NOT CONFIG_COMP_MODULE_SHARED_LIBRARY_BUILD)
add_subdirectory(mic_privacy_manager)
endif()
if(CONFIG_COMP_TONE)
add_local_sources(sof
tone.c
)
add_subdirectory(tone)
endif()
if(CONFIG_ZEPHYR_NATIVE_DRIVERS)
list(APPEND base_files host-zephyr.c)
Expand Down
8 changes: 1 addition & 7 deletions src/audio/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,6 @@ config COMP_STUBS
Select to force all 3P blocks to link against stubs rather than their libraries. This
should only be used in testing environments like fuzzers or CI.

config COMP_TONE
bool "Tone component"
select CORDIC_FIXED
help
Select for Tone component.
Warning: This component is deprecated and will be removed from SOF v2.8.

config COMP_KPB
bool "KPB component"
default y
Expand Down Expand Up @@ -154,6 +147,7 @@ rsource "src/Kconfig"
rsource "tdfb/Kconfig"
rsource "template/Kconfig"
rsource "tensorflow/Kconfig"
rsource "tone/Kconfig"
rsource "up_down_mixer/Kconfig"
rsource "volume/Kconfig"
# --- End Kconfig Sources (alphabetical order) ---
Expand Down
12 changes: 12 additions & 0 deletions src/audio/tone/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# SPDX-License-Identifier: BSD-3-Clause

if(CONFIG_COMP_TONE STREQUAL "m" AND DEFINED CONFIG_LLEXT)
add_subdirectory(llext ${PROJECT_BINARY_DIR}/tone_llext)
add_dependencies(app tone)
else()
if(CONFIG_IPC_MAJOR_3)
add_local_sources(sof tone.c tone-ipc3.c)
elseif(CONFIG_IPC_MAJOR_4)
add_local_sources(sof tone.c tone-ipc4.c)
endif()
endif()
16 changes: 16 additions & 0 deletions src/audio/tone/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# SPDX-License-Identifier: BSD-3-Clause

config COMP_TONE
tristate "Tone component"
default m if LIBRARY_DEFAULT_MODULAR
default y
depends on COMP_MODULE_ADAPTER
depends on IPC_MAJOR_4
Copy link
Collaborator

@lyakh lyakh Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it IPC4-only now? But you still have "if IPC3" code in this PR, confused

Copy link
Collaborator Author

@ranj063 ranj063 Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lyakh only IPC4 is supported now. I left the IPC3 code because Daniel requested to keep it but it doesnt work and needs to be fixed

Copy link
Collaborator

@lyakh lyakh Dec 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ranj063 ok, can we then put a comment in Kconfig, explaining, that the dependency on IPC4 is temporary and will be removed once IPC3 support is fixed? OTOH, we could also leave out this dependency and just put a comment here or in CMakeLists.txt that tone is currently broken IPC3 and just not enable it in any configurations that we're using. And if someone enables it - they'll know what they're doing. Or add a message(WARNING ...) to a cmake-file

select CORDIC_FIXED
help
Select for Tone component. This component is used to generate
audio tones (sine waves) at specified frequencies when the Tone
mode is enabled. The two other modes it supports are silence where
it generates 0s and passthrough where the input is passed to the
output. Warning: This component is untested with IPC_MAJOR_3 and
is unavailable.
7 changes: 7 additions & 0 deletions src/audio/tone/llext/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Copyright (c) 2025 Intel Corporation.
# SPDX-License-Identifier: Apache-2.0

sof_llext_build("tone"
SOURCES ../tone.c ../tone-ipc4.c
LIB openmodules
)
6 changes: 6 additions & 0 deletions src/audio/tone/llext/llext.toml.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#include <tools/rimage/config/platform.toml>
#define LOAD_TYPE "2"
#include "../tone.toml"

[module]
count = __COUNTER__
Loading
Loading