feat: add verifiers to the search #184
Conversation
markshenouda
commented
Dec 16, 2025
markshenouda
commented
Reviewed commit 25285be which extracts token mapping to a variable and simplifies the verifiers prop by passing
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| verifiers={uniqueVerifiers.map((verifier) => ({ | ||
| id: verifier.id, | ||
| name: verifier.name, | ||
| type: verifier.type, | ||
| logo: verifier.logo, | ||
| totalNetworks: verifier.totalNetworks, | ||
| }))} |
There was a problem hiding this comment.
On the Verifiers page, uniqueVerifiers is passed to both the tokens prop (lines 73-77) and this new verifiers prop. This will cause verifiers to appear twice in search results: once under "Tokens" and once under "Verifiers". Consider passing an empty array for tokens here since this page focuses on verifiers.
| verifiers={uniqueVerifiers.map((verifier) => ({ | |
| id: verifier.id, | |
| name: verifier.name, | |
| type: verifier.type, | |
| logo: verifier.logo, | |
| totalNetworks: verifier.totalNetworks, | |
| }))} | |
| verifiers={uniqueVerifiers.map((verifier) => ({ | |
| id: verifier.id, | |
| name: verifier.name, | |
| type: verifier.type, | |
| logo: verifier.logo, | |
| totalNetworks: verifier.totalNetworks, | |
| }))} |
Fix it with Roo Code or mention @roomote and request a fix.
Zelig880
left a comment
Zelig880
left a comment
There was a problem hiding this comment.
One comment that apply to many part of the code
| verifiers={allVerifiers.map((verifier) => ({ | ||
| id: verifier.id, | ||
| name: verifier.name, | ||
| type: verifier.type, | ||
| logo: verifier.logo, | ||
| totalNetworks: verifier.totalNetworks, | ||
| }))} |
There was a problem hiding this comment.
This mapping does not seem to be necessary. You are mapping to the same props name, it should be removed. (unlerss I am not seeing something hidden)
note: Same apply for all other occurances of this
* update: Token details page * update: Lane latest data * fix: lint * remove: unused console.log * remove: unused console.log * update: token drawer to include verifiers * refactor: extract realtime data logic into reusable hooks and components - Create custom hooks for data fetching: * useTokenRateLimits - single lane rate limits * useMultiLaneRateLimits - multiple lanes in parallel * useTokenFinality - token finality data - Add RateLimitCell component to replace complex nested ternaries - Create singleton realtimeDataService instance to avoid multiple instantiations - Add rate-limit-formatter utilities for consistent formatting - Update LaneDrawer, TokenDrawer, and TokenChainsTable to use new hooks - Add proper cleanup in useEffect hooks to prevent memory leaks Benefits: - Reduced code duplication (~133 lines removed) - Improved readability with <RateLimitCell> vs 7-level nested ternaries - Better separation of concerns - More testable code - Proper cleanup handling * fix: use enums for tabs * refactor: cleanup Lane's table logic * refactor: token drawer filtering logic * fix: token grid in chain page design * fix: the token card desgin * fix: lint * feat: add verifiers to the search (#184) * feat: add verifiers to the search * refactor: simplify verifiers mapping in Chain component * refactor: simplify verifiers mapping in CCIP components * refactor: optimize token mapping for verifiers in CCIP components * feat: enhance verifiers data handling with token support * fix: typecheck
