-
Notifications
You must be signed in to change notification settings - Fork 39
Log to file #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Log to file #84
Conversation
- use include pattern instead of rendering in class
- download zip file including logs and information about setup
- added utility classes
src/class-tiny-compress-client.php
Outdated
| * @since 3.6.8 | ||
| * @var int | ||
| */ | ||
| const API_TIMEOUT = 10; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the connecttimeout should be short, but the full request can be quite long, depending on the complexity, load on the servers and size of the image the compression can take a long time.
| global $wpdb; | ||
|
|
||
| return array( | ||
| 'php_version' => phpversion(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldnt it make sense to include the output of phpinfo()? then we can omit a lot of the code here.
I do not know if phpinfo() contains sensitive data though, if it does, we should not do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could store a phpinfo() html file in the diagnostics zip. Not sure if that is valuable though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might use the level below env see flags. It could be valuable regarding php.ini config right?
…task/logging-troubleshooting
We had two customers reporting two different issues which we could not figure out. Often times this is due to setup configurations but it is hard to figure out.
Having some diagnostics and logs should make it easier to troubleshoot these issues.
Good to know
Screenshots

Customers can turn on logging and download a diagnostics zip file from within settings