[PROD RELEASE] - WorkManager Changes - Connect Decommission #1633

kkartunov · 2025-04-09T07:01:35Z

Changes to be done in Work Manager while decommissioning Connect.

Updates:

Allow hyphen in url - asset library
feat: added show only my projects for project managers
PM-973 - invite by email

…ression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

PM-971 Allow hyphen in url - asset library

fix(PM-974) Allow project managers to view all projects

feat(PM-974): allow PM to view users and delete users from project

…email

fix(PM-974): projects list in challenges tab

PM-973 invite by mail

PM-973 - fetch project invites sepparately

github-actions · 2025-04-09T12:57:58Z

src/actions/projects.js

  UPDATE_PROJECT_ATTACHMENT_SUCCESS,
-  REMOVE_PROJECT_ATTACHMENT_SUCCESS
+  REMOVE_PROJECT_ATTACHMENT_SUCCESS,
+  LOAD_PROJECT_INVITES


It looks like a new constant LOAD_PROJECT_INVITES has been added. Ensure that this constant is defined in the ../config/constants file and is being used appropriately in the codebase.

github-actions · 2025-04-09T12:58:01Z

src/actions/projects.js

  fetchMemberProjects,
-  updateProjectApi
+  updateProjectApi,
+  getProjectInvites


Please ensure that getProjectInvites is actually used in the code. If it's not used, consider removing it to keep the imports clean and avoid unnecessary dependencies.

github-actions · 2025-04-09T12:58:04Z

src/components/ProjectCard/index.js

 import styles from './ProjectCard.module.scss'

-const ProjectCard = ({ projectName, projectStatus, projectId, selected }) => {
+const ProjectCard = ({ projectName, projectStatus, projectId, selected, isInvited }) => {


Consider adding a default value for the isInvited prop to ensure it is always a boolean. This can prevent potential issues if the prop is undefined.

github-actions · 2025-04-09T12:58:09Z

src/containers/Challenges/index.js

+    const { auth } = this.props
+
+    if (checkIsUserInvited(auth.token, this.props.projectDetail)) {
+      this.props.history.push(`/projects/${this.props.projectId}/invitation`)


The change from this.props.projectDetail.id to this.props.projectId may affect the logic if projectId is not equivalent to projectDetail.id. Ensure that projectId is correctly set and used throughout the component to avoid potential mismatches.

github-actions · 2025-04-09T12:58:12Z

src/containers/ProjectInvitations/index.js

+import { toastr } from 'react-redux-toastr'
+import { checkIsUserInvited } from '../../util/tc'
+import { isEmpty } from 'lodash'
+import { loadProjectInvites } from '../../actions/projects'


The import statement has been changed from loadProject to loadProjectInvites. Ensure that this change is intentional and that the loadProjectInvites function is defined and used correctly in the code. If loadProject is still needed elsewhere in the file, consider importing both functions.

github-actions · 2025-04-09T12:58:15Z

src/containers/ProjectInvitations/index.js

+  container: styles.modalContainer
+}
+
+const ProjectInvitations = ({ match, auth, isProjectLoading, history, projectDetail, loadProjectInvites }) => {


The prop loadProject has been renamed to loadProjectInvites. Ensure that all instances where loadProject is used within this component are updated accordingly to prevent potential errors.

github-actions · 2025-04-09T12:58:18Z

src/containers/ProjectInvitations/index.js

+
+    if (isProjectLoading || isEmpty(projectDetail)) {
+      if (!isProjectLoading) {
+        loadProjectInvites(projectId)


The function loadProjectInvites is being called instead of loadProject. Ensure that this change is intentional and that loadProjectInvites is defined and behaves as expected for the given context.

github-actions · 2025-04-09T12:58:22Z

src/containers/ProjectInvitations/index.js

+
+    // await for the project details to propagate
+    await delay(1000)
+    await loadProjectInvites(projectId)


The function loadProjectInvites is used here, replacing loadProject. Ensure that loadProjectInvites is defined and correctly implemented to handle the logic previously managed by loadProject. If loadProjectInvites is a new function, verify that it is imported and available in this context.

github-actions · 2025-04-09T12:58:22Z

src/containers/ProjectInvitations/index.js

+    // await for the project details to fetch
+    await delay(1000)
+    history.push(status === PROJECT_MEMBER_INVITE_STATUS_ACCEPTED ? `/projects/${projectId}/challenges` : '/projects')
+  }, [projectId, invitation, loadProjectInvites, history])


The dependency array for the useEffect hook has been updated to include loadProjectInvites instead of loadProject. Ensure that loadProjectInvites is a stable reference (e.g., memoized or defined outside of the component) to prevent unnecessary re-renders.

github-actions · 2025-04-09T12:58:25Z

src/containers/ProjectInvitations/index.js

+  auth: PropTypes.object.isRequired,
+  isProjectLoading: PropTypes.bool,
+  history: PropTypes.object,
+  loadProjectInvites: PropTypes.func.isRequired,


The function name loadProjectInvites suggests it only loads project invitations. Ensure that this change aligns with the intended functionality and that other parts of the codebase are updated accordingly to reflect this change.

github-actions · 2025-04-09T12:58:25Z

src/containers/ProjectInvitations/index.js

+const mapStateToProps = ({ projects, auth }) => {
+  return {
+    projectDetail: projects.projectDetail,
+    isProjectLoading: projects.isLoading || projects.isProjectInvitationsLoading,


The condition projects.isLoading || projects.isProjectInvitationsLoading may lead to unexpected behavior if both flags are true. Consider if this logic accurately reflects the loading state you want to convey.

github-actions · 2025-04-09T12:58:28Z

src/containers/Projects/index.js

 import PropTypes from 'prop-types'
 import Loader from '../../components/Loader'
-import { checkAdminOrCopilot } from '../../util/tc'
+import { checkAdminOrCopilot, checkIsUserInvited, checkManager } from '../../util/tc'


Consider alphabetizing the import statements for better readability and maintainability. This will help in quickly locating specific imports.

github-actions · 2025-04-09T12:58:30Z

src/containers/Projects/index.js

            {projects.map(p => (
              <li key={p.id}>
                <ProjectCard
+                  isInvited={!!checkIsUserInvited(auth.token, p)}


The function checkIsUserInvited is used here, but it's not clear from the diff if this function is defined and imported correctly. Ensure that checkIsUserInvited is defined and imported in this file to avoid runtime errors.

github-actions · 2025-04-09T12:58:32Z

src/reducers/projects.js

  ADD_PROJECT_ATTACHMENT_SUCCESS,
  UPDATE_PROJECT_ATTACHMENT_SUCCESS,
-  REMOVE_PROJECT_ATTACHMENT_SUCCESS
+  REMOVE_PROJECT_ATTACHMENT_SUCCESS,


There is a missing trailing comma in the import statement. Consider adding a comma after REMOVE_PROJECT_ATTACHMENT_SUCCESS to maintain consistency with the added lines.

github-actions · 2025-04-09T12:58:36Z

src/reducers/projects.js

+        ...state,
+        projectDetail: {
+          ...state.projectDetail,
+          invites: []


Consider checking if state.projectDetail is defined before spreading it to prevent potential runtime errors if state.projectDetail is undefined.

github-actions · 2025-04-09T12:58:36Z

src/reducers/projects.js

+        ...state,
+        projectDetail: {
+          ...state.projectDetail,
+          invites: action.payload


Consider checking if action.payload is an array before assigning it to invites to ensure that the data structure is as expected.

github-actions · 2025-04-09T12:58:38Z

src/services/projects.js

+ * @returns {Promise<*>}
+ */
+export async function getProjectInvites (projectId) {
+  const response = await axiosInstance.get(`${PROJECTS_API_URL}/${projectId}/invites`)


Consider adding error handling for the API request to ensure that any issues with the network or server are gracefully managed.

PM-973 - fix checkIsUserInvitedToProject

github-actions · 2025-04-09T14:28:43Z

src/containers/Challenges/index.js

  resetSidebarActiveParams
 } from '../../actions/sidebar'
-import { checkAdmin } from '../../util/tc'
+import { checkAdmin, checkIsUserInvitedToProject } from '../../util/tc'


The function name checkIsUserInvitedToProject suggests a more specific purpose than the previous checkIsUserInvited. Ensure that this change is intentional and that the function is correctly implemented to handle the specific context of checking if a user is invited to a project.

github-actions · 2025-04-09T14:28:47Z

src/containers/Challenges/index.js

+  componentDidUpdate () {
+    const { auth } = this.props
+
+    if (checkIsUserInvitedToProject(auth.token, this.props.projectDetail)) {


The function name has been changed from checkIsUserInvited to checkIsUserInvitedToProject. Ensure that this function is defined and correctly implemented elsewhere in the codebase, and that all references to the old function name have been updated accordingly.

github-actions · 2025-04-09T14:28:50Z

src/containers/ProjectEditor/index.js

 } from '../../actions/projects'
 import { setActiveProject } from '../../actions/sidebar'
-import { checkAdminOrCopilot, checkAdmin } from '../../util/tc'
+import { checkAdminOrCopilot, checkAdmin, checkIsUserInvitedToProject } from '../../util/tc'


The function checkIsUserInvited has been renamed to checkIsUserInvitedToProject. Ensure that all instances where this function is called are updated accordingly throughout the codebase to prevent any potential errors.

github-actions · 2025-04-09T14:28:54Z

src/containers/ProjectEditor/index.js

  componentDidUpdate () {
    const { auth } = this.props
+
+    if (checkIsUserInvitedToProject(auth.token, this.props.projectDetail)) {


The function name has been changed from checkIsUserInvited to checkIsUserInvitedToProject. Ensure that this function is defined and correctly implemented elsewhere in the codebase to avoid runtime errors.

github-actions · 2025-04-09T14:28:57Z

src/containers/ProjectInvitations/index.js

+import { connect } from 'react-redux'
+import { withRouter } from 'react-router-dom'
+import { toastr } from 'react-redux-toastr'
+import { checkIsUserInvitedToProject } from '../../util/tc'


The function name has been changed from checkIsUserInvited to checkIsUserInvitedToProject. Ensure that all references to this function throughout the codebase are updated accordingly to prevent any potential errors.

github-actions · 2025-04-09T14:29:01Z

src/containers/ProjectInvitations/index.js

+const ProjectInvitations = ({ match, auth, isProjectLoading, history, projectDetail, loadProjectInvites }) => {
+  const automaticAction = useMemo(() => [PROJECT_MEMBER_INVITE_STATUS_ACCEPTED, PROJECT_MEMBER_INVITE_STATUS_REFUSED].includes(match.params.action) ? match.params.action : undefined, [match.params])
+  const projectId = useMemo(() => parseInt(match.params.projectId), [match.params])
+  const invitation = useMemo(() => checkIsUserInvitedToProject(auth.token, projectDetail), [auth.token, projectDetail])


The function checkIsUserInvitedToProject is used here, replacing checkIsUserInvited. Ensure that this function is defined and correctly implemented elsewhere in the codebase, as this change might affect the logic of invitation checking.

github-actions · 2025-04-09T14:29:04Z

src/containers/Projects/index.js

 import PropTypes from 'prop-types'
 import Loader from '../../components/Loader'
-import { checkAdminOrCopilot } from '../../util/tc'
+import { checkAdminOrCopilot, checkIsUserInvitedToProject, checkManager } from '../../util/tc'


The function checkIsUserInvited has been renamed to checkIsUserInvitedToProject. Ensure that all instances of this function call throughout the codebase are updated to reflect this change to avoid any potential errors.

github-actions · 2025-04-09T14:29:07Z

src/containers/Projects/index.js

            {projects.map(p => (
              <li key={p.id}>
                <ProjectCard
+                  isInvited={!!checkIsUserInvitedToProject(auth.token, p)}


The function name has been changed from checkIsUserInvited to checkIsUserInvitedToProject. Ensure that this function is defined and correctly implemented elsewhere in the codebase to avoid any runtime errors.

github-actions · 2025-04-09T14:29:15Z

src/util/tc.js

  return isAdmin || (isCopilot && canManageProject)
 }

+export const checkIsUserInvitedToProject = (token, project) => {


Consider renaming the function to isUserInvitedToProject to follow the convention of starting boolean-returning function names with 'is'.

github-actions · 2025-04-09T14:29:15Z

src/util/tc.js

+  }
+
+  const tokenData = decodeToken(token)
+  return project && !_.isEmpty(project) && (_.find(project.invites, d => d.userId === tokenData.userId || d.email === tokenData.email))


The logic for checking if a user is invited now includes checking by email. Ensure that tokenData.email is always available and correctly populated to avoid potential undefined errors.

PM-973 - Update label for "cancel" on invitation modal

himaniraghav3 and others added 30 commits March 26, 2025 16:04

Allow hyphen in url - asset library

ff855cf

git copilot suggestion

a70e1a5

Redo the fix with minimal change

4d24155

Codeql test

6a43f63

re-iterate with codeql

619b5c0

Retest performance

1dee45f

Potential fix for code scanning alert no. 27: Inefficient regular exp…

a0fe205

…ression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

revert codeql suggestion

374be0c

Merge pull request #1621 from topcoder-platform/PM-971

c7d59d7

PM-971 Allow hyphen in url - asset library

feat: added show only my projects for project managers

1b719fb

fix: removed console log

441e6d7

fix: lint

592a0f3

PM-973 - move add user to own component

4fd1543

PM-973 - invite user modal

81a1173

PM-973 - invite by email

06ab559

Merge pull request #1622 from topcoder-platform/pm-974_1

90f0395

fix(PM-974) Allow project managers to view all projects

feat: allow PM to view users and delete users from project

41329e1

fix: all projects challenges

7eccfe3

Merge pull request #1624 from topcoder-platform/pm-974_2

18768fd

feat(PM-974): allow PM to view users and delete users from project

PM-973 - add invitation dialog after user accepts invitation through …

592b787

…email

Merge remote-tracking branch 'origin/develop' into PM-973_invite-by-mail

5823808

fix: projects list in challenges tab

b184e86

Merge pull request #1625 from topcoder-platform/pm-974_3

125cf7d

fix(PM-974): projects list in challenges tab

Merge pull request #1623 from topcoder-platform/PM-973_invite-by-mail

8af3cf0

PM-973 invite by mail

add AI PR Reviewer action

9605fa2

rename job

530c136

adds clear cache step

3ddfca7

workflow update

cf7491a

add @master ref

eedc3ff

job rename

ac1de1a

vas3a and others added 2 commits April 9, 2025 15:52

PM-973 - fetch project invites sepparately

e6f13e0

Merge pull request #1635 from topcoder-platform/PM-973_invite-by-mail

de8f892

PM-973 - fetch project invites sepparately

github-actions bot reviewed Apr 9, 2025

View reviewed changes

vas3a and others added 2 commits April 9, 2025 17:27

PM-973 - fix checkIsUserInvitedToProject

21d0574

Merge pull request #1636 from topcoder-platform/PM-973_invite-by-mail

2422565

PM-973 - fix checkIsUserInvitedToProject

github-actions bot reviewed Apr 9, 2025

View reviewed changes

vas3a and others added 2 commits April 10, 2025 09:48

PM-973 - Update label for "cancel" on invitation modal

5334423

Merge pull request #1637 from topcoder-platform/PM-973_invite-by-mail

7d0fcd9

PM-973 - Update label for "cancel" on invitation modal

kkartunov merged commit 5431440 into master Apr 10, 2025
3 of 5 checks passed

[PROD RELEASE] - WorkManager Changes - Connect Decommission #1633

[PROD RELEASE] - WorkManager Changes - Connect Decommission #1633

Uh oh!

Conversation

kkartunov commented Apr 9, 2025

Uh oh!

github-actions bot Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 9, 2025

Choose a reason for hiding this comment