[PROD RELEASE] - BA selection UI exposed to PMs #1641

kkartunov · 2025-04-16T15:46:32Z

As per https://topcoder.atlassian.net/browse/PM-1093

In Work Manager, the ‘Select Billing Account' feature to be available for 'Project Manager’ role in addition to the Admin role.

feat(PM-972): copilot invitation with email

fix(PM-574): show update/add billing address for project manager who belongs to the project

github-actions · 2025-04-16T15:46:55Z

src/components/ChallengesComponent/ChallengeList/index.js

    } = this.props
    const isReadOnly = checkReadOnlyRoles(this.props.auth.token) || loginUserRoleInProject === PROJECT_ROLES.READ
    const isAdmin = checkAdmin(this.props.auth.token)
+    const isManager = checkManager(this.props.auth.token)


Consider renaming isManager to isProjectManager for clarity, as it specifically checks for the Project Manager role.

github-actions · 2025-04-16T15:46:55Z

src/components/ChallengesComponent/ChallengeList/index.js

    const isAdmin = checkAdmin(this.props.auth.token)
+    const isManager = checkManager(this.props.auth.token)
+    const loginUserId = this.props.auth.user.userId
+    const isMemberOfActiveProject = activeProject && activeProject.members && activeProject.members.some(member => member.userId === loginUserId)


The variable isMemberOfActiveProject could be more descriptive. Consider renaming it to userIsMemberOfActiveProject to clearly indicate that it refers to the current user.

github-actions · 2025-04-16T15:47:00Z

src/components/UpdateBillingAccount/index.js

        <Fragment>
          <span className={styles.error}>No Billing Account set</span>
-          {isAdmin && (
+          {(isAdmin || (isManager && isMemberOfActiveProject)) && (


Consider using a more descriptive variable name for isManager to clarify its purpose, especially if it refers specifically to a Project Manager role. This can improve code readability and maintainability.

github-actions · 2025-04-16T15:47:04Z

src/components/UpdateBillingAccount/index.js

            {isBillingAccountExpired ? 'INACTIVE' : 'ACTIVE'}
          </span>{' '}
-          {isAdmin && (
+          {(isAdmin || (isManager && isMemberOfActiveProject)) && (


Consider extracting the condition (isAdmin || (isManager && isMemberOfActiveProject)) into a well-named variable or function to improve readability and maintainability of the code.

github-actions · 2025-04-16T15:47:07Z

src/components/UpdateBillingAccount/index.js

  projectId: PropTypes.number,
-  updateProject: PropTypes.func.isRequired
+  updateProject: PropTypes.func.isRequired,
+  isMemberOfActiveProject: PropTypes.bool.isRequired,


The prop type isMemberOfActiveProject is defined as PropTypes.bool.isRequired, but it's not clear from the context if this prop is being used in the component. Please ensure that this prop is utilized within the component logic.

github-actions · 2025-04-16T15:47:07Z

src/components/UpdateBillingAccount/index.js

-  updateProject: PropTypes.func.isRequired
+  updateProject: PropTypes.func.isRequired,
+  isMemberOfActiveProject: PropTypes.bool.isRequired,
+  isManager: PropTypes.bool.isRequired


The prop type isManager is defined as PropTypes.bool.isRequired, but it's not clear from the context if this prop is being used in the component. Please ensure that this prop is utilized within the component logic.

github-actions · 2025-04-16T15:47:16Z

src/components/Users/user-add.modal.js

+          role: userPermissionToAdd
+        })
+        if (failed) {
+          const error = get(failed, '0.message', 'Unable to invite user')


Consider using a more descriptive error message or logging additional details for debugging purposes when setting the error message for a failed invitation.

github-actions · 2025-04-16T15:47:16Z

src/components/Users/user-add.modal.js

+          setAddUserError(error)
+          setIsAdding(false)
+        } else {
+          onMemberInvited(invitations[0] || {})


Ensure that invitations[0] is not undefined before accessing it to avoid potential runtime errors. Consider adding a check or default value.

github-actions · 2025-04-16T15:47:19Z

src/components/Users/user-add.modal.js

 UserAddModalContent.propTypes = {
  projectId: PropTypes.number.isRequired,
  addNewProjectMember: PropTypes.func.isRequired,
+  onMemberInvited: PropTypes.func.isRequired,


The new prop onMemberInvited is marked as required, but there is no context provided in this diff about its usage or necessity. Ensure that this prop is indeed required and used appropriately within the component. If it's not used or optional, consider updating the prop type accordingly.

github-actions · 2025-04-16T15:47:28Z

src/containers/Users/index.js

+    fetchProjectById(projectId).then(async (project) => {
      const projectMembers = _.get(project, 'members')
      const invitedMembers = _.get(project, 'invites')
+      const invitedUserIds = _.filter(_.map(invitedMembers, 'userId'))


Consider checking if invitedMembers is not null or undefined before mapping over it to avoid potential runtime errors.

github-actions · 2025-04-16T15:47:29Z

src/containers/Users/index.js

      const projectMembers = _.get(project, 'members')
      const invitedMembers = _.get(project, 'invites')
+      const invitedUserIds = _.filter(_.map(invitedMembers, 'userId'))
+      const invitedUsers = await fetchInviteMembers(invitedUserIds)


Ensure that fetchInviteMembers handles cases where invitedUserIds might be an empty array, as this could lead to unnecessary API calls or errors.

github-actions · 2025-04-16T15:47:29Z

src/containers/Users/index.js

-        invitedMembers
+        invitedMembers: invitedMembers.map(m => ({
+          ...m,
+          email: m.email || invitedUsers[m.userId].email


Add a check to ensure invitedUsers[m.userId] exists before trying to access .email to prevent potential errors if the user is not found.

github-actions · 2025-04-16T15:47:33Z

src/services/projects.js


+/**
+ * This fetches the user corresponding to the given userIds
+ * @param {*} userIds


The parameter userIds is typed as *, which is not specific. Consider specifying the expected type, such as Array or Array<number>, to improve code readability and maintainability.

github-actions · 2025-04-16T15:47:34Z

src/services/projects.js

+ * @param {*} userIds
+ */
+export async function fetchInviteMembers (userIds) {
+  const url = `${MEMBERS_API_URL}?${userIds.map(id => `userIds[]=${id}`).join('&')}`


Consider adding error handling for the API request to ensure that any network or server errors are properly managed and do not cause the application to crash.

github-actions · 2025-04-16T15:47:37Z

src/services/projects.js

-    emails: [email],
-    role: role
-  })
+export async function inviteUserToProject (projectId, params) {


The function inviteUserToProject now accepts params instead of email and role separately. Ensure that the params object is validated properly before being passed to createProjectMemberInvite to prevent potential issues with missing or malformed data.

fix(PM-1077): handled errors for certain use cases

github-actions · 2025-04-22T14:02:48Z

src/components/Users/user-add.modal.js

-      addNewProjectMember(newUserInfo)
-      onClose()
+      if (userPermissionToAdd === PROJECT_ROLES.COPILOT) {
+        const { success: invitations = [], failed, ...rest } = await inviteUserToProject(projectId, {


Consider checking if rest.message is a string before using it in the condition on line 57 to ensure that it doesn't cause unexpected behavior if rest.message is not a string.

github-actions · 2025-04-22T14:02:48Z

src/components/Users/user-add.modal.js

+          role: userPermissionToAdd
+        })
+        if (failed) {
+          const error = get(failed, '0.message', 'User cannot be invited')


The error message has been changed from 'Unable to invite user' to 'User cannot be invited'. Ensure that this change aligns with the user experience and error messaging guidelines.

github-actions · 2025-04-22T14:02:51Z

src/containers/Users/index.js

-        invitedMembers
+        invitedMembers: invitedMembers.map(m => ({
+          ...m,
+          email: m.email || invitedUsers[m.userId].handle


The change from email to handle might affect how invited members are identified or displayed. Ensure that this change aligns with the intended functionality and that handle provides the necessary information for the 'Select Billing Account' feature.

fix(PM-1077): show invite handle if email doesn't exist in invite

github-actions · 2025-04-22T22:31:20Z

src/components/UserCard/index.js

        <div className={styles.item}>
          <div className={cn(styles.col5)}>
-            {isInvite ? user.email : user.handle}
+            {isInvite ? (user.email || user.handle) : user.handle}


The change introduces a fallback to user.handle if user.email is not available when isInvite is true. Consider checking if both user.email and user.handle are defined before using them to prevent potential issues with undefined values. For example, you could use user.email ? user.email : user.handle to ensure that user.handle is only used when user.email is not available.

github-advanced-security · 2025-04-22T22:32:47Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Sync Master into develop

hentrymartin added 4 commits April 10, 2025 22:36

feat: copilot invitation with email

3b7fbe2

Merge pull request #1638 from topcoder-platform/pm-972

bbe6312

feat(PM-972): copilot invitation with email

fix: show update billing address for project manager who belongs to org

997d8f0

Merge pull request #1640 from topcoder-platform/pm-574

3c464c0

fix(PM-574): show update/add billing address for project manager who belongs to the project

github-actions bot reviewed Apr 16, 2025

View reviewed changes

hentrymartin added 2 commits April 16, 2025 18:33

fix: handled errors for certain use cases

c8c1075

Merge pull request #1643 from topcoder-platform/pm-972_1

70f514e

fix(PM-1077): handled errors for certain use cases

github-actions bot reviewed Apr 22, 2025

View reviewed changes

hentrymartin added 4 commits April 22, 2025 23:22

fix: show handle for invit

e04fae1

fix: show handle for invit

50d6f0a

removed circle ci changes

b0d0f48

Merge pull request #1644 from topcoder-platform/pm-1077

9f1728f

fix(PM-1077): show invite handle if email doesn't exist in invite

github-actions bot reviewed Apr 22, 2025

View reviewed changes

Merge pull request #1645 from topcoder-platform/master

00f7089

Sync Master into develop

kkartunov merged commit 64cfc53 into master Apr 24, 2025
6 of 7 checks passed

[PROD RELEASE] - BA selection UI exposed to PMs #1641

[PROD RELEASE] - BA selection UI exposed to PMs #1641

Uh oh!

Conversation

kkartunov commented Apr 16, 2025

Uh oh!

github-actions bot Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-advanced-security bot commented Apr 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants